From f52031ecdf4520e6d404553691da193356e58691 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Mon, 18 Apr 2022 15:22:23 +0200 Subject: feat(test): skip internal stack frames for errors (#14302) This commit changes "deno test" to filter out stack frames if it is beneficial to the user. This is the case when there are stack frames coming from "internal" code below frames coming from user code. Co-authored-by: Nayeem Rahman --- cli/tests/testdata/test/steps/failing_steps.out | 1 - cli/tests/testdata/test/steps/invalid_usage.out | 24 +++++++----------------- 2 files changed, 7 insertions(+), 18 deletions(-) (limited to 'cli/tests/testdata/test/steps') diff --git a/cli/tests/testdata/test/steps/failing_steps.out b/cli/tests/testdata/test/steps/failing_steps.out index a5fd9d74d..2095eda51 100644 --- a/cli/tests/testdata/test/steps/failing_steps.out +++ b/cli/tests/testdata/test/steps/failing_steps.out @@ -50,7 +50,6 @@ Error: Fail test. throw new Error("Fail test."); ^ at [WILDCARD]/failing_steps.ts:[WILDCARD] - at [WILDCARD] failures: diff --git a/cli/tests/testdata/test/steps/invalid_usage.out b/cli/tests/testdata/test/steps/invalid_usage.out index 9107cb4e0..3b9921f14 100644 --- a/cli/tests/testdata/test/steps/invalid_usage.out +++ b/cli/tests/testdata/test/steps/invalid_usage.out @@ -10,16 +10,14 @@ inner missing await ... step ... inner ... pending ([WILDCARD]) Error: Parent scope completed before test step finished execution. Ensure all steps are awaited (ex. `await t.step(...)`). - at postValidation [WILDCARD] - at testStepSanitizer [WILDCARD] + at [WILDCARD] + at async TestContext.step [WILDCARD] FAILED ([WILDCARD]) Error: There were still test steps running after the current scope finished execution. Ensure all steps are awaited (ex. `await t.step(...)`). await t.step("step", (t) => { ^ - at postValidation [WILDCARD] - at testStepSanitizer [WILDCARD] + at [WILDCARD] at async fn ([WILDCARD]/invalid_usage.ts:[WILDCARD]) - at async Object.testStepSanitizer [WILDCARD] FAILED ([WILDCARD]) parallel steps with sanitizers ... step 1 ... pending ([WILDCARD]) @@ -28,10 +26,8 @@ parallel steps with sanitizers ... * parallel steps with sanitizers > step 1 await t.step("step 2", () => {}); ^ - at preValidation ([WILDCARD]) - at testStepSanitizer ([WILDCARD]) - at [WILDCARD]/invalid_usage.ts:[WILDCARD] at [WILDCARD] + at [WILDCARD]/invalid_usage.ts:[WILDCARD] FAILED ([WILDCARD]) parallel steps when first has sanitizer ... step 1 ... pending ([WILDCARD]) @@ -40,10 +36,8 @@ parallel steps when first has sanitizer ... * parallel steps when first has sanitizer > step 1 await t.step({ ^ - at preValidation ([WILDCARD]) - at testStepSanitizer ([WILDCARD]) - at [WILDCARD]/invalid_usage.ts:[WILDCARD] at [WILDCARD] + at [WILDCARD]/invalid_usage.ts:[WILDCARD] FAILED ([WILDCARD]) parallel steps when second has sanitizer ... step 1 ... ok ([WILDCARD]) @@ -52,10 +46,8 @@ parallel steps when second has sanitizer ... * parallel steps when second has sanitizer > step 1 await t.step({ ^ - at preValidation ([WILDCARD]) - at testStepSanitizer ([WILDCARD]) - at [WILDCARD]/invalid_usage.ts:[WILDCARD] at [WILDCARD] + at [WILDCARD]/invalid_usage.ts:[WILDCARD] FAILED ([WILDCARD]) parallel steps where only inner tests have sanitizers ... step 1 ... @@ -67,8 +59,7 @@ parallel steps where only inner tests have sanitizers ... * parallel steps where only inner tests have sanitizers > step 1 await t.step({ ^ - at preValidation ([WILDCARD]) - at testStepSanitizer ([WILDCARD]) + at [WILDCARD] at [WILDCARD]/invalid_usage.ts:[WILDCARD] FAILED ([WILDCARD]) FAILED ([WILDCARD]) @@ -81,7 +72,6 @@ Error: Cannot run test step after parent scope has finished execution. Ensure an ^ at TestContext.step ([WILDCARD]) at [WILDCARD]/invalid_usage.ts:[WILDCARD] - at [WILDCARD] ./test/steps/invalid_usage.ts > top level missing await Error: There were still test steps running after the current scope finished execution. Ensure all steps are awaited (ex. `await t.step(...)`). -- cgit v1.2.3