From be888c068cbe42c1cb93d9885827dc97aa40d6f6 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Mon, 8 Jan 2024 19:30:36 -0500 Subject: fix(task): do not eagerly auto-install packages in package.json when `"nodeModulesDir": false` (#21858) There's no need to auto-install the package.json if the user is not using a node_modules directory. Closes #21850 --- .../testdata/task/package_json_node_modules_dir_false/bin.out | 2 ++ .../testdata/task/package_json_node_modules_dir_false/deno.json | 3 +++ .../task/package_json_node_modules_dir_false/package.json | 9 +++++++++ 3 files changed, 14 insertions(+) create mode 100644 cli/tests/testdata/task/package_json_node_modules_dir_false/bin.out create mode 100644 cli/tests/testdata/task/package_json_node_modules_dir_false/deno.json create mode 100644 cli/tests/testdata/task/package_json_node_modules_dir_false/package.json (limited to 'cli/tests/testdata/task/package_json_node_modules_dir_false') diff --git a/cli/tests/testdata/task/package_json_node_modules_dir_false/bin.out b/cli/tests/testdata/task/package_json_node_modules_dir_false/bin.out new file mode 100644 index 000000000..d5d59d551 --- /dev/null +++ b/cli/tests/testdata/task/package_json_node_modules_dir_false/bin.out @@ -0,0 +1,2 @@ +Task echo deno eval 'console.log(1)' +1 diff --git a/cli/tests/testdata/task/package_json_node_modules_dir_false/deno.json b/cli/tests/testdata/task/package_json_node_modules_dir_false/deno.json new file mode 100644 index 000000000..23a325cfc --- /dev/null +++ b/cli/tests/testdata/task/package_json_node_modules_dir_false/deno.json @@ -0,0 +1,3 @@ +{ + "nodeModulesDir": false +} diff --git a/cli/tests/testdata/task/package_json_node_modules_dir_false/package.json b/cli/tests/testdata/task/package_json_node_modules_dir_false/package.json new file mode 100644 index 000000000..081e076b9 --- /dev/null +++ b/cli/tests/testdata/task/package_json_node_modules_dir_false/package.json @@ -0,0 +1,9 @@ +{ + "scripts": { + "echo": "deno eval 'console.log(1)'" + }, + "dependencies": { + "@denotest/bin": "0.5", + "other": "npm:@denotest/bin@1.0" + } +} -- cgit v1.2.3