From 300fd07fad3dee74730517ba91b2e7314632fc3f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Wed, 16 Nov 2022 01:40:03 +0100 Subject: fix(npm): don't fail if conditional exports don't contains types (#16651) If resolving types for an npm package, we didn't find "types" entry in the conditional exports declaration we were falling-through to regular resolution, instead of short-circuiting and giving up on resolving types, which might lead to unwarranted errors. Closes https://github.com/denoland/deno/issues/16649 --- .../no-types-in-conditional-exports/1.0.0/lib/foo-esm.js | 3 +++ .../no-types-in-conditional-exports/1.0.0/lib/foo.js | 3 +++ .../no-types-in-conditional-exports/1.0.0/package.json | 14 ++++++++++++++ 3 files changed, 20 insertions(+) create mode 100644 cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/lib/foo-esm.js create mode 100644 cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/lib/foo.js create mode 100644 cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/package.json (limited to 'cli/tests/testdata/npm/registry/@denotest') diff --git a/cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/lib/foo-esm.js b/cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/lib/foo-esm.js new file mode 100644 index 000000000..0ead93520 --- /dev/null +++ b/cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/lib/foo-esm.js @@ -0,0 +1,3 @@ +export default { + "foo": "bar" +}; \ No newline at end of file diff --git a/cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/lib/foo.js b/cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/lib/foo.js new file mode 100644 index 000000000..dca03a472 --- /dev/null +++ b/cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/lib/foo.js @@ -0,0 +1,3 @@ +module.exports = { + "foo": "bar" +}; \ No newline at end of file diff --git a/cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/package.json b/cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/package.json new file mode 100644 index 000000000..524394480 --- /dev/null +++ b/cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/package.json @@ -0,0 +1,14 @@ +{ + "name": "@denotest/no-types-in-conditional-exports", + "version": "1.0.0", + "main": "./lib/foo.js", + "module": "./lib/foo-esm.js", + "exports": { + ".": { + "require": "./lib/foo.js", + "import": "./lib/foo-esm.js" + }, + "./*": "./*" + }, + "type": "module" +} -- cgit v1.2.3