From 0223ad72a999d1237162a96228f568d973b115fb Mon Sep 17 00:00:00 2001 From: Elian Cordoba Date: Fri, 14 Jul 2023 13:47:18 -0300 Subject: fix(npm): improve error message on directory import in npm package (#19538) Co-authored-by: David Sherret --- cli/tests/testdata/npm/directory_import/folder_index_js.out | 7 +++++++ cli/tests/testdata/npm/directory_import/folder_index_js.ts | 2 ++ cli/tests/testdata/npm/directory_import/folder_no_index.out | 6 ++++++ cli/tests/testdata/npm/directory_import/folder_no_index.ts | 2 ++ 4 files changed, 17 insertions(+) create mode 100644 cli/tests/testdata/npm/directory_import/folder_index_js.out create mode 100644 cli/tests/testdata/npm/directory_import/folder_index_js.ts create mode 100644 cli/tests/testdata/npm/directory_import/folder_no_index.out create mode 100644 cli/tests/testdata/npm/directory_import/folder_no_index.ts (limited to 'cli/tests/testdata/npm/directory_import') diff --git a/cli/tests/testdata/npm/directory_import/folder_index_js.out b/cli/tests/testdata/npm/directory_import/folder_index_js.out new file mode 100644 index 000000000..72f285fc0 --- /dev/null +++ b/cli/tests/testdata/npm/directory_import/folder_index_js.out @@ -0,0 +1,7 @@ +Download http://localhost:4545/npm/registry/@denotest/sub-folders +Download http://localhost:4545/npm/registry/@denotest/sub-folders/1.0.0.tgz +error: Directory import [WILDCARD]folder_index_js is not supported resolving import from file:///[WILDCARD]/directory_import/folder_index_js.ts +Did you mean to import index.js within the directory? + +Caused by: + [WILDCARD] diff --git a/cli/tests/testdata/npm/directory_import/folder_index_js.ts b/cli/tests/testdata/npm/directory_import/folder_index_js.ts new file mode 100644 index 000000000..b0d51fcd9 --- /dev/null +++ b/cli/tests/testdata/npm/directory_import/folder_index_js.ts @@ -0,0 +1,2 @@ +import test from "npm:@denotest/sub-folders/folder_index_js"; +console.log(test); diff --git a/cli/tests/testdata/npm/directory_import/folder_no_index.out b/cli/tests/testdata/npm/directory_import/folder_no_index.out new file mode 100644 index 000000000..86ac88207 --- /dev/null +++ b/cli/tests/testdata/npm/directory_import/folder_no_index.out @@ -0,0 +1,6 @@ +Download http://localhost:4545/npm/registry/@denotest/sub-folders +Download http://localhost:4545/npm/registry/@denotest/sub-folders/1.0.0.tgz +error: Directory import [WILDCARD]folder_no_index is not supported resolving import from file:///[WILDCARD]/folder_no_index.ts + +Caused by: + [WILDCARD] diff --git a/cli/tests/testdata/npm/directory_import/folder_no_index.ts b/cli/tests/testdata/npm/directory_import/folder_no_index.ts new file mode 100644 index 000000000..4c5fb7ec0 --- /dev/null +++ b/cli/tests/testdata/npm/directory_import/folder_no_index.ts @@ -0,0 +1,2 @@ +import test from "npm:@denotest/sub-folders/folder_no_index"; +console.log(test); -- cgit v1.2.3