From a1d823e27d1b605b5658fddc1c9273667f0e9e84 Mon Sep 17 00:00:00 2001
From: David Sherret <dsherret@users.noreply.github.com>
Date: Fri, 1 Dec 2023 15:12:10 -0500
Subject: feat(compile): support discovering modules for more dynamic arguments
 (#21381)

This PR causes Deno to include more files in the graph based on how a
template literal looks that's provided to a dynamic import:

```ts
const file = await import(`./dir/${expr}`);
```

In this case, it will search the `dir` directory and descendant
directories for any .js/jsx/etc modules and include them in the graph.

To opt out of this behaviour, move the template literal to a separate
line:

```ts
const specifier = `./dir/${expr}`
const file = await import(specifier);
```
---
 .../testdata/compile/dynamic_imports_tmp_lit/main.info.out | 10 ++++++++++
 cli/tests/testdata/compile/dynamic_imports_tmp_lit/main.js | 14 ++++++++++++++
 .../compile/dynamic_imports_tmp_lit/other/data.json        |  3 +++
 .../compile/dynamic_imports_tmp_lit/other/sub/data2.json   |  3 +++
 .../testdata/compile/dynamic_imports_tmp_lit/sub/a.js      |  1 +
 .../testdata/compile/dynamic_imports_tmp_lit/sub/b.ts      |  1 +
 6 files changed, 32 insertions(+)
 create mode 100644 cli/tests/testdata/compile/dynamic_imports_tmp_lit/main.info.out
 create mode 100644 cli/tests/testdata/compile/dynamic_imports_tmp_lit/main.js
 create mode 100644 cli/tests/testdata/compile/dynamic_imports_tmp_lit/other/data.json
 create mode 100644 cli/tests/testdata/compile/dynamic_imports_tmp_lit/other/sub/data2.json
 create mode 100644 cli/tests/testdata/compile/dynamic_imports_tmp_lit/sub/a.js
 create mode 100644 cli/tests/testdata/compile/dynamic_imports_tmp_lit/sub/b.ts

(limited to 'cli/tests/testdata/compile')

diff --git a/cli/tests/testdata/compile/dynamic_imports_tmp_lit/main.info.out b/cli/tests/testdata/compile/dynamic_imports_tmp_lit/main.info.out
new file mode 100644
index 000000000..57d730a64
--- /dev/null
+++ b/cli/tests/testdata/compile/dynamic_imports_tmp_lit/main.info.out
@@ -0,0 +1,10 @@
+local: [WILDCARD]main.js
+type: JavaScript
+dependencies: 4 unique
+size: [WILDCARD]
+
+file:///[WILDCARD]/dynamic_imports_tmp_lit/main.js ([WILDCARD])
+├── file:///[WILDCARD]/dynamic_imports_tmp_lit/sub/a.js ([WILDCARD])
+├── file:///[WILDCARD]/dynamic_imports_tmp_lit/sub/b.ts ([WILDCARD])
+├── file:///[WILDCARD]/dynamic_imports_tmp_lit/other/data.json ([WILDCARD])
+└── file:///[WILDCARD]/dynamic_imports_tmp_lit/other/sub/data2.json ([WILDCARD])
diff --git a/cli/tests/testdata/compile/dynamic_imports_tmp_lit/main.js b/cli/tests/testdata/compile/dynamic_imports_tmp_lit/main.js
new file mode 100644
index 000000000..3bda59772
--- /dev/null
+++ b/cli/tests/testdata/compile/dynamic_imports_tmp_lit/main.js
@@ -0,0 +1,14 @@
+const fileNames = [
+  "a.js",
+  "b.ts",
+];
+
+for (const fileName of fileNames) {
+  await import(`./sub/${fileName}`);
+}
+
+const jsonFileNames = ["data.json", "sub/data2.json"];
+for (const fileName of jsonFileNames) {
+  const mod = await import(`./other/${fileName}`, { with: { type: "json" } });
+  console.log(mod.default);
+}
diff --git a/cli/tests/testdata/compile/dynamic_imports_tmp_lit/other/data.json b/cli/tests/testdata/compile/dynamic_imports_tmp_lit/other/data.json
new file mode 100644
index 000000000..0131e01e4
--- /dev/null
+++ b/cli/tests/testdata/compile/dynamic_imports_tmp_lit/other/data.json
@@ -0,0 +1,3 @@
+{
+  "data": 5
+}
diff --git a/cli/tests/testdata/compile/dynamic_imports_tmp_lit/other/sub/data2.json b/cli/tests/testdata/compile/dynamic_imports_tmp_lit/other/sub/data2.json
new file mode 100644
index 000000000..858a13cdd
--- /dev/null
+++ b/cli/tests/testdata/compile/dynamic_imports_tmp_lit/other/sub/data2.json
@@ -0,0 +1,3 @@
+{
+  "data": 1
+}
diff --git a/cli/tests/testdata/compile/dynamic_imports_tmp_lit/sub/a.js b/cli/tests/testdata/compile/dynamic_imports_tmp_lit/sub/a.js
new file mode 100644
index 000000000..7b2a34601
--- /dev/null
+++ b/cli/tests/testdata/compile/dynamic_imports_tmp_lit/sub/a.js
@@ -0,0 +1 @@
+console.log("a");
diff --git a/cli/tests/testdata/compile/dynamic_imports_tmp_lit/sub/b.ts b/cli/tests/testdata/compile/dynamic_imports_tmp_lit/sub/b.ts
new file mode 100644
index 000000000..6d012e7f1
--- /dev/null
+++ b/cli/tests/testdata/compile/dynamic_imports_tmp_lit/sub/b.ts
@@ -0,0 +1 @@
+console.log("b");
-- 
cgit v1.2.3