From fa52b5e73374dfd1e76f82207dd59020b6520148 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Thu, 27 Jul 2023 14:09:02 -0400 Subject: fix: do not include jsx without `@ts-check` in tsc roots (#19964) Closes #19928 --- cli/tests/testdata/check/jsx_not_checked/main.jsx | 21 +++++++++++++++++++++ cli/tests/testdata/check/jsx_not_checked/main.out | 11 +++++++++++ cli/tests/testdata/check/jsx_not_checked/other.ts | 5 +++++ 3 files changed, 37 insertions(+) create mode 100644 cli/tests/testdata/check/jsx_not_checked/main.jsx create mode 100644 cli/tests/testdata/check/jsx_not_checked/main.out create mode 100644 cli/tests/testdata/check/jsx_not_checked/other.ts (limited to 'cli/tests/testdata/check/jsx_not_checked') diff --git a/cli/tests/testdata/check/jsx_not_checked/main.jsx b/cli/tests/testdata/check/jsx_not_checked/main.jsx new file mode 100644 index 000000000..8de05f9f7 --- /dev/null +++ b/cli/tests/testdata/check/jsx_not_checked/main.jsx @@ -0,0 +1,21 @@ +// should not error about jsx-runtime not being found in types here +/** @jsxImportSource npm:react@18.2.0 */ + +import "./other.ts"; + +export default ( + <> +

Hello world

+

This is a JSX page

+ +); + +/** + * @param {number} a + * @param {number} b + */ +function add(a, b) { + return a + b; +} + +console.log(add("1", "2")); diff --git a/cli/tests/testdata/check/jsx_not_checked/main.out b/cli/tests/testdata/check/jsx_not_checked/main.out new file mode 100644 index 000000000..a4e1c60e4 --- /dev/null +++ b/cli/tests/testdata/check/jsx_not_checked/main.out @@ -0,0 +1,11 @@ +Download http://localhost:4545/npm/registry/react +Download http://localhost:4545/npm/registry/loose-envify +Download http://localhost:4545/npm/registry/js-tokens +Download http://localhost:4545/npm/registry/react/react-18.2.0.tgz +Download http://localhost:4545/npm/registry/loose-envify/loose-envify-1.4.0.tgz +Download http://localhost:4545/npm/registry/js-tokens/js-tokens-4.0.0.tgz +Check file:///[WILDCARD]/jsx_not_checked/main.jsx +error: TS2345 [ERROR]: Argument of type 'string' is not assignable to parameter of type 'number'. +console.log(add("1", "2")); + ~~~ + at file:///[WILDCARD]/other.ts:5:17 diff --git a/cli/tests/testdata/check/jsx_not_checked/other.ts b/cli/tests/testdata/check/jsx_not_checked/other.ts new file mode 100644 index 000000000..47995cb0f --- /dev/null +++ b/cli/tests/testdata/check/jsx_not_checked/other.ts @@ -0,0 +1,5 @@ +function add(a: number, b: number) { + return a + b; +} + +console.log(add("1", "2")); -- cgit v1.2.3