From edca01c35e7f3f76ec98dd912314db16995e2a4f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= <biwanczuk@gmail.com>
Date: Wed, 19 Apr 2023 00:32:21 +0200
Subject: chore: disable flaky Node compat tests (#18760)

I'm not able to reproduce any of the failures from CI on my machine.

I'm going to disable these tests for now as they are holding us back.
---
 .../test-child-process-can-write-to-stdout.js      | 29 ----------
 ...process-execFile-promisified-abortController.js | 66 ----------------------
 2 files changed, 95 deletions(-)
 delete mode 100644 cli/tests/node_compat/test/parallel/test-child-process-can-write-to-stdout.js
 delete mode 100644 cli/tests/node_compat/test/parallel/test-child-process-execFile-promisified-abortController.js

(limited to 'cli/tests/node_compat/test')

diff --git a/cli/tests/node_compat/test/parallel/test-child-process-can-write-to-stdout.js b/cli/tests/node_compat/test/parallel/test-child-process-can-write-to-stdout.js
deleted file mode 100644
index 11dbf9bcb..000000000
--- a/cli/tests/node_compat/test/parallel/test-child-process-can-write-to-stdout.js
+++ /dev/null
@@ -1,29 +0,0 @@
-// deno-fmt-ignore-file
-// deno-lint-ignore-file
-
-// Copyright Joyent and Node contributors. All rights reserved. MIT license.
-// Taken from Node 18.12.1
-// This file is automatically generated by "node/_tools/setup.ts". Do not modify this file manually
-
-'use strict';
-// Tests that a spawned child process can write to stdout without throwing.
-// See https://github.com/nodejs/node-v0.x-archive/issues/1899.
-
-require('../common');
-const fixtures = require('../common/fixtures');
-const assert = require('assert');
-const spawn = require('child_process').spawn;
-
-const child = spawn(process.argv[0], [
-  fixtures.path('GH-1899-output.js'),
-]);
-let output = '';
-
-child.stdout.on('data', function(data) {
-  output += data;
-});
-
-child.on('exit', function(code, signal) {
-  assert.strictEqual(code, 0);
-  assert.strictEqual(output, 'hello, world!\n');
-});
diff --git a/cli/tests/node_compat/test/parallel/test-child-process-execFile-promisified-abortController.js b/cli/tests/node_compat/test/parallel/test-child-process-execFile-promisified-abortController.js
deleted file mode 100644
index fe3e8765e..000000000
--- a/cli/tests/node_compat/test/parallel/test-child-process-execFile-promisified-abortController.js
+++ /dev/null
@@ -1,66 +0,0 @@
-// deno-fmt-ignore-file
-// deno-lint-ignore-file
-
-// Copyright Joyent and Node contributors. All rights reserved. MIT license.
-// Taken from Node 18.12.1
-// This file is automatically generated by "node/_tools/setup.ts". Do not modify this file manually
-
-// TODO(PolarETech): The args passed to promisified() should not need to
-// include "require.ts".
-
-'use strict';
-
-const common = require('../common');
-const assert = require('assert');
-const { promisify } = require('util');
-const execFile = require('child_process').execFile;
-const fixtures = require('../common/fixtures');
-
-const echoFixture = fixtures.path('echo.js');
-const promisified = promisify(execFile);
-const invalidArgTypeError = {
-  code: 'ERR_INVALID_ARG_TYPE',
-  name: 'TypeError'
-};
-
-{
-  // Verify that the signal option works properly
-  const ac = new AbortController();
-  const signal = ac.signal;
-  const promise = promisified(process.execPath, ['require.ts', echoFixture, 0], { signal });
-
-  ac.abort();
-
-  assert.rejects(
-    promise,
-    { name: 'AbortError' }
-  ).then(common.mustCall());
-}
-
-{
-  // Verify that the signal option works properly when already aborted
-  const signal = AbortSignal.abort();
-
-  assert.rejects(
-    promisified(process.execPath, ['require.ts', echoFixture, 0], { signal }),
-    { name: 'AbortError' }
-  ).then(common.mustCall());
-}
-
-{
-  // Verify that if something different than Abortcontroller.signal
-  // is passed, ERR_INVALID_ARG_TYPE is thrown
-  const signal = {};
-  assert.throws(() => {
-    promisified(process.execPath, ['require.ts', echoFixture, 0], { signal });
-  }, invalidArgTypeError);
-}
-
-{
-  // Verify that if something different than Abortcontroller.signal
-  // is passed, ERR_INVALID_ARG_TYPE is thrown
-  const signal = 'world!';
-  assert.throws(() => {
-    promisified(process.execPath, ['require.ts', echoFixture, 0], { signal });
-  }, invalidArgTypeError);
-}
-- 
cgit v1.2.3