From f5e46c9bf2f50d66a953fa133161fc829cecff06 Mon Sep 17 00:00:00 2001 From: Matt Mastracci Date: Sat, 10 Feb 2024 13:22:13 -0700 Subject: chore: move cli/tests/ -> tests/ (#22369) This looks like a massive PR, but it's only a move from cli/tests -> tests, and updates of relative paths for files. This is the first step towards aggregate all of the integration test files under tests/, which will lead to a set of integration tests that can run without the CLI binary being built. While we could leave these tests under `cli`, it would require us to keep a more complex directory structure for the various test runners. In addition, we have a lot of complexity to ignore various test files in the `cli` project itself (cargo publish exclusion rules, autotests = false, etc). And finally, the `tests/` folder will eventually house the `test_ffi`, `test_napi` and other testing code, reducing the size of the root repo directory. For easier review, the extremely large and noisy "move" is in the first commit (with no changes -- just a move), while the remainder of the changes to actual files is in the second commit. --- .../test-child-process-exec-kill-throws.js | 42 ---------------------- 1 file changed, 42 deletions(-) delete mode 100644 cli/tests/node_compat/test/parallel/test-child-process-exec-kill-throws.js (limited to 'cli/tests/node_compat/test/parallel/test-child-process-exec-kill-throws.js') diff --git a/cli/tests/node_compat/test/parallel/test-child-process-exec-kill-throws.js b/cli/tests/node_compat/test/parallel/test-child-process-exec-kill-throws.js deleted file mode 100644 index 6a28c2a18..000000000 --- a/cli/tests/node_compat/test/parallel/test-child-process-exec-kill-throws.js +++ /dev/null @@ -1,42 +0,0 @@ -// deno-fmt-ignore-file -// deno-lint-ignore-file - -// Copyright Joyent and Node contributors. All rights reserved. MIT license. -// Taken from Node 18.8.0 -// This file is automatically generated by "node/_tools/setup.ts". Do not modify this file manually - -// TODO(PolarETech): The process.argv[3] check should be argv[2], and the -// command passed to exec() should not need to include "run", "-A", -// and "require.ts". - -'use strict'; -// Flags: --expose-internals -const common = require('../common'); -const assert = require('assert'); -const cp = require('child_process'); - -if (process.argv[3] === 'child') { - // Since maxBuffer is 0, this should trigger an error. - console.log('foo'); -} else { - const internalCp = require('internal/child_process'); - - // Monkey patch ChildProcess#kill() to kill the process and then throw. - const kill = internalCp.ChildProcess.prototype.kill; - - internalCp.ChildProcess.prototype.kill = function() { - kill.apply(this, arguments); - throw new Error('mock error'); - }; - - const cmd = `"${process.execPath}" run -A require.ts "${__filename}" child`; - const options = { maxBuffer: 0, killSignal: 'SIGKILL' }; - - const child = cp.exec(cmd, options, common.mustCall((err, stdout, stderr) => { - // Verify that if ChildProcess#kill() throws, the error is reported. - assert.strictEqual(err.message, 'mock error', err); - assert.strictEqual(stdout, ''); - assert.strictEqual(stderr, ''); - assert.strictEqual(child.killed, true); - })); -} -- cgit v1.2.3