From d868bae90a5437c75c52ac831c59030120cfdc88 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Mon, 9 Oct 2023 10:57:32 +0200 Subject: chore: disable flaky Node compat test (#20832) --- cli/tests/node_compat/test/internet/test-dns.js | 30 +++++++++++++------------ 1 file changed, 16 insertions(+), 14 deletions(-) (limited to 'cli/tests/node_compat/test/internet/test-dns.js') diff --git a/cli/tests/node_compat/test/internet/test-dns.js b/cli/tests/node_compat/test/internet/test-dns.js index 9741db8e6..986bb0d3f 100644 --- a/cli/tests/node_compat/test/internet/test-dns.js +++ b/cli/tests/node_compat/test/internet/test-dns.js @@ -172,24 +172,26 @@ TEST(async function test_resolveMx(done) { checkWrap(req); }); -TEST(function test_resolveMx_failure(done) { - dnsPromises.resolveMx(addresses.NOT_FOUND) - .then(common.mustNotCall()) - .catch(common.mustCall((err) => { - assert.strictEqual(err.code, 'ENOTFOUND'); - })); +// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN` +// instead of `ENOTFOUND`. +// TEST(function test_resolveMx_failure(done) { +// dnsPromises.resolveMx(addresses.NOT_FOUND) +// .then(common.mustNotCall()) +// .catch(common.mustCall((err) => { +// assert.strictEqual(err.code, 'ENOTFOUND'); +// })); - const req = dns.resolveMx(addresses.NOT_FOUND, function(err, result) { - assert.ok(err instanceof Error); - assert.strictEqual(err.code, 'ENOTFOUND'); +// const req = dns.resolveMx(addresses.NOT_FOUND, function(err, result) { +// assert.ok(err instanceof Error); +// assert.strictEqual(err.code, 'ENOTFOUND'); - assert.strictEqual(result, undefined); +// assert.strictEqual(result, undefined); - done(); - }); +// done(); +// }); - checkWrap(req); -}); +// checkWrap(req); +// }); TEST(async function test_resolveNs(done) { function validateResult(result) { -- cgit v1.2.3