From f7c298e2972e6a1eb8f9329272ed8e8c9549266c Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Mon, 26 Apr 2021 13:28:38 -0400 Subject: Remove denort optimization (#10350) denort is an optimization to "deno compile" to produce slightly smaller output. It's a decent idea, but causes a lot of negative side-effects: - Deno's link time is a source of constant agony both locally and in CI, denort doubles link time. - The release process is a long and arduous undertaking with many manual steps. denort necessitates an additional manual zip + upload from M1 apple computers. - The "deno compile" interface is complicated with the "--lite" option. This is confusing for uses ("why wouldn't you want lite?"). The benefits of this feature do not outweigh the negatives. We must find a different approach to optimizing "deno compile" output. --- cli/tests/integration_tests.rs | 11 ----------- 1 file changed, 11 deletions(-) (limited to 'cli/tests/integration_tests.rs') diff --git a/cli/tests/integration_tests.rs b/cli/tests/integration_tests.rs index 92deb9416..bb99cf49b 100644 --- a/cli/tests/integration_tests.rs +++ b/cli/tests/integration_tests.rs @@ -5637,17 +5637,6 @@ console.log("finish"); .contains("PermissionDenied: Requires write access")); } - #[test] - fn denort_direct_use_error() { - let status = Command::new(util::denort_exe_path()) - .current_dir(util::root_path()) - .spawn() - .unwrap() - .wait() - .unwrap(); - assert!(!status.success()); - } - #[tokio::test(flavor = "multi_thread", worker_threads = 2)] async fn test_resolve_dns() { use std::collections::BTreeMap; -- cgit v1.2.3