From b75f3b5ca0952db8b50cf417c107f3f14fe582d5 Mon Sep 17 00:00:00 2001 From: Matt Mastracci Date: Mon, 30 Oct 2023 11:49:19 -0600 Subject: feat(ext/websocket): split websocket read/write halves (#20579) Fixes some UB when sending and receiving at the same time. --- cli/tests/integration/js_unit_tests.rs | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) (limited to 'cli/tests/integration') diff --git a/cli/tests/integration/js_unit_tests.rs b/cli/tests/integration/js_unit_tests.rs index a13db02d7..f110f8aa6 100644 --- a/cli/tests/integration/js_unit_tests.rs +++ b/cli/tests/integration/js_unit_tests.rs @@ -112,12 +112,22 @@ util::unit_test_factory!( fn js_unit_test(test: String) { let _g = util::http_server(); - let mut deno = util::deno_cmd() + let mut deno = util::deno_cmd(); + let deno = deno .current_dir(util::root_path()) .arg("test") .arg("--unstable") .arg("--location=http://js-unit-tests/foo/bar") - .arg("--no-prompt") + .arg("--no-prompt"); + + // TODO(mmastrac): it would be better to just load a test CA for all tests + let deno = if test == "websocket_test" { + deno.arg("--unsafely-ignore-certificate-errors") + } else { + deno + }; + + let mut deno = deno .arg("-A") .arg(util::tests_path().join("unit").join(format!("{test}.ts"))) .stderr(Stdio::piped()) -- cgit v1.2.3