From 9853c96cc4686a6cd1ffa1e9081c012b8df72ff7 Mon Sep 17 00:00:00 2001 From: Nayeem Rahman Date: Wed, 27 Apr 2022 00:06:10 +0100 Subject: refactor: Remove PrettyJsError and js_error_create_fn (#14378) This commit: - removes "fmt_errors::PrettyJsError" in favor of "format_js_error" fn - removes "deno_core::JsError::create" and "deno_core::RuntimeOptions::js_error_create_fn" - adds new option to "deno_runtime::ops::worker_host::init" --- cli/tests/integration/compile_tests.rs | 10 ++++++++-- cli/tests/integration/worker_tests.rs | 6 ++++++ 2 files changed, 14 insertions(+), 2 deletions(-) (limited to 'cli/tests/integration') diff --git a/cli/tests/integration/compile_tests.rs b/cli/tests/integration/compile_tests.rs index 3d2a17ecc..4e45adc07 100644 --- a/cli/tests/integration/compile_tests.rs +++ b/cli/tests/integration/compile_tests.rs @@ -105,9 +105,12 @@ fn standalone_error() { assert!(!output.status.success()); assert_eq!(output.stdout, b""); let stderr = String::from_utf8(output.stderr).unwrap(); + let stderr = util::strip_ansi_codes(&stderr).to_string(); // On Windows, we cannot assert the file path (because '\'). // Instead we just check for relevant output. - assert!(stderr.contains("error: Error: boom!\n at boom (file://")); + assert!(stderr.contains("error: Uncaught Error: boom!")); + assert!(stderr.contains("throw new Error(\"boom!\");")); + assert!(stderr.contains("\n at boom (file://")); assert!(stderr.contains("standalone_error.ts:2:11")); assert!(stderr.contains("at foo (file://")); assert!(stderr.contains("standalone_error.ts:5:5")); @@ -148,9 +151,12 @@ fn standalone_error_module_with_imports() { println!("{:#?}", &output); assert_eq!(output.stdout, b"hello\n"); let stderr = String::from_utf8(output.stderr).unwrap(); + let stderr = util::strip_ansi_codes(&stderr).to_string(); // On Windows, we cannot assert the file path (because '\'). // Instead we just check for relevant output. - assert!(stderr.contains("error: Error: boom!\n at file://")); + assert!(stderr.contains("error: Uncaught Error: boom!")); + assert!(stderr.contains("throw new Error(\"boom!\");")); + assert!(stderr.contains("\n at file://")); assert!(stderr.contains("standalone_error_module_with_imports_2.ts:2:7")); } diff --git a/cli/tests/integration/worker_tests.rs b/cli/tests/integration/worker_tests.rs index 57faaa6d3..63d5ccbd3 100644 --- a/cli/tests/integration/worker_tests.rs +++ b/cli/tests/integration/worker_tests.rs @@ -104,3 +104,9 @@ itest!(worker_terminate_tla_crash { args: "run --quiet --reload workers/terminate_tla_crash.js", output: "workers/terminate_tla_crash.js.out", }); + +itest!(worker_error_event { + args: "run --quiet -A workers/error_event.ts", + output: "workers/error_event.ts.out", + exit_code: 1, +}); -- cgit v1.2.3