From 300fd07fad3dee74730517ba91b2e7314632fc3f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Wed, 16 Nov 2022 01:40:03 +0100 Subject: fix(npm): don't fail if conditional exports don't contains types (#16651) If resolving types for an npm package, we didn't find "types" entry in the conditional exports declaration we were falling-through to regular resolution, instead of short-circuiting and giving up on resolving types, which might lead to unwarranted errors. Closes https://github.com/denoland/deno/issues/16649 --- cli/tests/integration/npm_tests.rs | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'cli/tests/integration') diff --git a/cli/tests/integration/npm_tests.rs b/cli/tests/integration/npm_tests.rs index 3de6e5f2d..787dab815 100644 --- a/cli/tests/integration/npm_tests.rs +++ b/cli/tests/integration/npm_tests.rs @@ -263,6 +263,14 @@ itest!(types_ambient_module_import_map { exit_code: 1, }); +itest!(no_types_in_conditional_exports { + args: "run --check --unstable npm/no_types_in_conditional_exports/main.ts", + output: "npm/no_types_in_conditional_exports/main.out", + exit_code: 0, + envs: env_vars(), + http_server: true, +}); + #[test] fn parallel_downloading() { let (out, _err) = util::run_and_collect_output_with_args( -- cgit v1.2.3