From 8b31fc23cd80de9baa62535e95367da7a21c9cfd Mon Sep 17 00:00:00 2001 From: Nayeem Rahman Date: Fri, 15 Apr 2022 15:08:09 +0100 Subject: refactor: Move source map lookups to core (#14274) The following transformations gradually faced by "JsError" have all been moved up front to "JsError::from_v8_exception()": - finding the first non-"deno:" source line; - moving "JsError::script_resource_name" etc. into the first error stack in case of syntax errors; - source mapping "JsError::script_resource_name" etc. when wrapping the error even though the frame locations are source mapped earlier; - removing "JsError::{script_resource_name,line_number,start_column,end_column}" entirely in favour of "js_error.frames.get(0)". We also no longer pass a js-side callback to "core/02_error.js" from cli. I avoided doing this on previous occasions because the source map lookups were in an awkward place. --- cli/tests/integration/test_tests.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'cli/tests/integration/test_tests.rs') diff --git a/cli/tests/integration/test_tests.rs b/cli/tests/integration/test_tests.rs index bf0ceb038..6a0d5c1ab 100644 --- a/cli/tests/integration/test_tests.rs +++ b/cli/tests/integration/test_tests.rs @@ -246,7 +246,7 @@ itest!(shuffle_with_seed { }); itest!(aggregate_error { - args: "test test/aggregate_error.ts", + args: "test --quiet test/aggregate_error.ts", exit_code: 1, output: "test/aggregate_error.out", }); -- cgit v1.2.3