From 0b296c6378c46c18de7c3838b2a3e1d13eb9bd87 Mon Sep 17 00:00:00 2001 From: Nayeem Rahman Date: Fri, 28 Apr 2023 14:21:55 +0100 Subject: fix(repl): don't panic on undefined exception (#18888) Fixes regression from #18878 where `Promise.reject()`, `Promise.reject(undefined)` and `reportError(undefined)` panic in the REPL. Fixes `throw undefined` printing `Uncaught Unknown exception` instead of `Uncaught undefined`. --- cli/tests/integration/repl_tests.rs | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'cli/tests/integration/repl_tests.rs') diff --git a/cli/tests/integration/repl_tests.rs b/cli/tests/integration/repl_tests.rs index d9966fe8f..f8987e20b 100644 --- a/cli/tests/integration/repl_tests.rs +++ b/cli/tests/integration/repl_tests.rs @@ -824,6 +824,20 @@ fn repl_report_error() { }); } +#[test] +fn repl_error_undefined() { + util::with_pty(&["repl"], |mut console| { + console.write_line(r#"throw undefined;"#); + console.expect("Uncaught undefined"); + console.write_line(r#"Promise.reject();"#); + console.expect("Promise { undefined }"); + console.expect("Uncaught (in promise) undefined"); + console.write_line(r#"reportError(undefined);"#); + console.expect("undefined"); + console.expect("Uncaught undefined"); + }); +} + #[test] fn pty_aggregate_error() { util::with_pty(&["repl"], |mut console| { -- cgit v1.2.3