From 86c3c4f34397a29c2bf1847bddfea562a2369a4f Mon Sep 17 00:00:00 2001 From: Matt Mastracci Date: Mon, 27 Mar 2023 16:01:52 -0600 Subject: feat(core): initialize SQLite off-main-thread (#18401) This gets SQLite off the flamegraph and reduces initialization time by somewhere between 0.2ms and 0.5ms. In addition, I took the opportunity to move all the cache management code to a single place and reduce duplication. While the PR has a net gain of lines, much of that is just being a bit more deliberate with how we're recovering from errors. The existing caches had various policies for dealing with cache corruption, so I've unified them and tried to isolate the decisions we make for recovery in a single place (see `open_connection` in `CacheDB`). The policy I chose was: 1. Retry twice to open on-disk caches 2. If that fails, try to delete the file and recreate it on-disk 3. If we fail to delete the file or re-create a new cache, use a fallback strategy that can be chosen per-cache: InMemory (temporary cache for the process run), BlackHole (ignore writes, return empty reads), or Error (fail on every operation). The caches all use the same general code now, and share the cache failure recovery policy. In addition, it cleans up a TODO in the `NodeAnalysisCache`. --- cli/tests/integration/inspector_tests.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'cli/tests/integration/inspector_tests.rs') diff --git a/cli/tests/integration/inspector_tests.rs b/cli/tests/integration/inspector_tests.rs index 17f48ba5c..067963786 100644 --- a/cli/tests/integration/inspector_tests.rs +++ b/cli/tests/integration/inspector_tests.rs @@ -11,11 +11,11 @@ use deno_runtime::deno_fetch::reqwest; use deno_runtime::deno_websocket::tokio_tungstenite; use deno_runtime::deno_websocket::tokio_tungstenite::tungstenite; use std::io::BufRead; -use std::process::Child; use test_util as util; use test_util::TempDir; use tokio::net::TcpStream; use util::http_server; +use util::DenoChild; struct InspectorTester { socket_tx: SplitSink< @@ -30,7 +30,7 @@ struct InspectorTester { >, >, notification_filter: Box bool + 'static>, - child: Child, + child: DenoChild, stderr_lines: Box>, stdout_lines: Box>, } @@ -40,7 +40,7 @@ fn ignore_script_parsed(msg: &str) -> bool { } impl InspectorTester { - async fn create(mut child: Child, notification_filter: F) -> Self + async fn create(mut child: DenoChild, notification_filter: F) -> Self where F: FnMut(&str) -> bool + 'static, { -- cgit v1.2.3