From 064a73f7a08eb12d99fcdf8844e9ce5db62be78b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Mon, 9 Sep 2024 22:44:29 +0100 Subject: BREAKING: Remove `--unstable` flag (#25522) This commit effectively removes the --unstable flag. It's still being parsed, but it only prints a warning that a granular flag should be used instead and doesn't actually enable any unstable feature. Closes https://github.com/denoland/deno/issues/25485 Closes https://github.com/denoland/deno/issues/23237 --- cli/standalone/binary.rs | 2 +- cli/standalone/mod.rs | 7 ------- 2 files changed, 1 insertion(+), 8 deletions(-) (limited to 'cli/standalone') diff --git a/cli/standalone/binary.rs b/cli/standalone/binary.rs index 27308c901..1e84e1398 100644 --- a/cli/standalone/binary.rs +++ b/cli/standalone/binary.rs @@ -624,7 +624,7 @@ impl<'a> DenoCompileBinaryWriter<'a> { }, node_modules, unstable_config: UnstableConfig { - legacy_flag_enabled: cli_options.legacy_unstable_flag(), + legacy_flag_enabled: false, bare_node_builtins: cli_options.unstable_bare_node_builtins(), sloppy_imports: cli_options.unstable_sloppy_imports(), features: cli_options.unstable_features(), diff --git a/cli/standalone/mod.rs b/cli/standalone/mod.rs index f1f687eed..0a08296d9 100644 --- a/cli/standalone/mod.rs +++ b/cli/standalone/mod.rs @@ -682,12 +682,6 @@ pub async fn run( let feature_checker = Arc::new({ let mut checker = FeatureChecker::default(); checker.set_exit_cb(Box::new(crate::unstable_exit_cb)); - // TODO(bartlomieju): enable, once we deprecate `--unstable` in favor - // of granular --unstable-* flags. - // feature_checker.set_warn_cb(Box::new(crate::unstable_warn_cb)); - if metadata.unstable_config.legacy_flag_enabled { - checker.enable_legacy_unstable(); - } for feature in metadata.unstable_config.features { // `metadata` is valid for the whole lifetime of the program, so we // can leak the string here. @@ -733,7 +727,6 @@ pub async fn run( seed: metadata.seed, unsafely_ignore_certificate_errors: metadata .unsafely_ignore_certificate_errors, - unstable: metadata.unstable_config.legacy_flag_enabled, create_hmr_runner: None, create_coverage_collector: None, node_ipc: None, -- cgit v1.2.3