From 5c1deac0cfe66ef27020aa0e863c16f3bc2afb50 Mon Sep 17 00:00:00 2001 From: Ry Dahl Date: Wed, 6 Nov 2019 12:17:28 -0500 Subject: Remove CoreResource::inspect_repr method (#3274) Towards simplifying (or better removing entirely) the CoreResource trait. Resources should be any bit of privileged heap allocated memory that needs to be referenced from JS, not very specific trait implementations. Therefore CoreResource should be pushed towards being as general as possible. --- cli/ops/repl.rs | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'cli/ops') diff --git a/cli/ops/repl.rs b/cli/ops/repl.rs index 4a3ba68d4..ba63c5109 100644 --- a/cli/ops/repl.rs +++ b/cli/ops/repl.rs @@ -24,11 +24,7 @@ pub fn init(i: &mut Isolate, s: &ThreadSafeState) { struct ReplResource(Arc>); -impl CoreResource for ReplResource { - fn inspect_repr(&self) -> &str { - "repl" - } -} +impl CoreResource for ReplResource {} #[derive(Deserialize)] #[serde(rename_all = "camelCase")] @@ -49,7 +45,7 @@ fn op_repl_start( let repl = repl::Repl::new(history_path); let resource = ReplResource(Arc::new(Mutex::new(repl))); let mut table = resources::lock_resource_table(); - let rid = table.add(Box::new(resource)); + let rid = table.add("repl", Box::new(resource)); Ok(JsonOp::Sync(json!(rid))) } -- cgit v1.2.3