From 47f7bed677a6b72e873712de8f3988ea891710e4 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Wed, 8 May 2024 22:45:06 -0400 Subject: chore: enable clippy::print_stdout and clippy::print_stderr (#23732) 1. Generally we should prefer to use the `log` crate. 2. I very often accidentally commit `eprintln`s. When we should use `println` or `eprintln`, it's not too bad to be a bit more verbose and ignore the lint rule. --- cli/ops/jupyter.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'cli/ops/jupyter.rs') diff --git a/cli/ops/jupyter.rs b/cli/ops/jupyter.rs index e7e206de5..1c60bc2bc 100644 --- a/cli/ops/jupyter.rs +++ b/cli/ops/jupyter.rs @@ -76,13 +76,13 @@ pub fn op_print( if is_err { if let Err(err) = sender.send(StdioMsg::Stderr(msg.into())) { - eprintln!("Failed to send stderr message: {}", err); + log::error!("Failed to send stderr message: {}", err); } return Ok(()); } if let Err(err) = sender.send(StdioMsg::Stdout(msg.into())) { - eprintln!("Failed to send stdout message: {}", err); + log::error!("Failed to send stdout message: {}", err); } Ok(()) } -- cgit v1.2.3