From 9bdc9e4ecb7227c80384206f6d7f869f183e4525 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Wed, 6 Dec 2023 14:24:00 -0500 Subject: fix(npm): do not create symlink for non-system optional dep in node_modules directory (#21478) Closes https://github.com/denoland/deno/issues/21476 --- cli/npm/managed/resolvers/local.rs | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'cli/npm') diff --git a/cli/npm/managed/resolvers/local.rs b/cli/npm/managed/resolvers/local.rs index 4051c9c31..84fd488f4 100644 --- a/cli/npm/managed/resolvers/local.rs +++ b/cli/npm/managed/resolvers/local.rs @@ -388,10 +388,13 @@ async fn sync_resolution_with_fs( .join("node_modules"); let mut dep_setup_cache = setup_cache.with_dep(&package_folder_name); for (name, dep_id) in &package.dependencies { - let dep_cache_folder_id = snapshot - .package_from_id(dep_id) - .unwrap() - .get_package_cache_folder_id(); + let dep = snapshot.package_from_id(dep_id).unwrap(); + if package.optional_dependencies.contains(name) + && !dep.system.matches_system(system_info) + { + continue; // this isn't a dependency for the current system + } + let dep_cache_folder_id = dep.get_package_cache_folder_id(); let dep_folder_name = get_package_folder_id_folder_name(&dep_cache_folder_id); if dep_setup_cache.insert(name, &dep_folder_name) { -- cgit v1.2.3