From 033b70af19300a4e34dcf19ab0031245bfc19625 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Fri, 24 Feb 2023 19:35:43 -0500 Subject: fix(npm): lazily install package.json dependencies only when necessary (#17931) This lazily does an "npm install" when any package name matches what's found in the package.json or when running a script from package.json with deno task. Part of #17916 Closes #17928 --- cli/npm/resolvers/mod.rs | 14 -------------- 1 file changed, 14 deletions(-) (limited to 'cli/npm/resolvers') diff --git a/cli/npm/resolvers/mod.rs b/cli/npm/resolvers/mod.rs index f68eeac26..0027698c0 100644 --- a/cli/npm/resolvers/mod.rs +++ b/cli/npm/resolvers/mod.rs @@ -19,7 +19,6 @@ use deno_runtime::deno_node::RequireNpmResolver; use global::GlobalNpmPackageResolver; use serde::Deserialize; use serde::Serialize; -use std::collections::BTreeMap; use std::path::Path; use std::path::PathBuf; use std::sync::Arc; @@ -224,19 +223,6 @@ impl NpmPackageResolver { self.resolution.has_packages() } - /// Adds the package reqs from a package.json if they exist. - pub async fn add_package_json_deps( - &self, - maybe_package_json_deps: Option<&BTreeMap>, - ) -> Result<(), AnyError> { - if let Some(deps) = maybe_package_json_deps { - let mut package_reqs = deps.values().cloned().collect::>(); - package_reqs.sort(); // deterministic resolution - self.add_package_reqs(package_reqs).await?; - } - Ok(()) - } - /// Adds package requirements to the resolver and ensures everything is setup. pub async fn add_package_reqs( &self, -- cgit v1.2.3