From fa22956a8616c34482b10bb3ae1aed76ad017c3e Mon Sep 17 00:00:00 2001 From: Luke Channings <461449+LukeChannings@users.noreply.github.com> Date: Sat, 15 Oct 2022 16:21:04 +0100 Subject: refactor(build): better handle old glibc (#16238) Follow-up to #16208. - Refactors build.rs behaviour to use `-exported_symbols_list` / `--export-dynamic-symbol-list` - Since all build systems now rely on a symbols list file, I have added `generate_exported_symbols_list`, which derives the symbol list file depending on the platform, which makes `tools/napi/generate_link_win.js` redundant. - Fixes a missed instance of `i8` being used instead of `c_char` Co-authored-by: Divy Srivastava --- cli/napi_sym/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'cli/napi_sym') diff --git a/cli/napi_sym/README.md b/cli/napi_sym/README.md index 80bb2be0f..b3e2ab43b 100644 --- a/cli/napi_sym/README.md +++ b/cli/napi_sym/README.md @@ -24,11 +24,11 @@ fn napi_get_boolean( ### `symbol_exports.json` -A file containing the symbols that need to be put into the exectable's dynamic +A file containing the symbols that need to be put into the executable's dynamic symbol table at link-time. This is done using `/DEF:` on Windows, `-exported_symbol,_` on macOS and `--export-dynamic-symbol=` on Linux. See [`cli/build.rs`](../build.rs). On Windows, you need to generate the `.def` file by running -[`tools/napi/generate_link_win.js`](../../tools/napi/generate_link_win.js). +[`tools/napi/generate_symbols_lists.js`](../../tools/napi/generate_symbols_lists.js). -- cgit v1.2.3