From a2488ae79200abfcbad0f0f8b084a3ff8e183880 Mon Sep 17 00:00:00 2001 From: Luke Channings <461449+LukeChannings@users.noreply.github.com> Date: Mon, 10 Oct 2022 03:29:31 +0100 Subject: fix(npm): support compiling on linux/aarch64 (#16208) Changes introduced in #13633 have broken the ability to compile for linux/aarch64 - specifically the use of a `i8` as a char type, which is an `u8` on linux/aarch64. This PR: - Replaces instances of `i8` with the architecture-aware wrapper type `c_char` - Skips the use of `--export-dynamic-symbol` on linux-aarch64, because the target environments often rely on older libc/binutils versions --- cli/napi/env.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'cli/napi') diff --git a/cli/napi/env.rs b/cli/napi/env.rs index 24dc8af81..df9af522f 100644 --- a/cli/napi/env.rs +++ b/cli/napi/env.rs @@ -1,6 +1,7 @@ // Copyright 2018-2022 the Deno authors. All rights reserved. MIT license. use deno_runtime::deno_napi::*; +use std::os::raw::c_char; /// # Safety /// @@ -125,7 +126,7 @@ const NODE_VERSION: napi_node_version = napi_node_version { major: 17, minor: 4, patch: 0, - release: "Deno\0".as_ptr() as *const i8, + release: "Deno\0".as_ptr() as *const c_char, }; #[napi_sym::napi_sym] -- cgit v1.2.3