From 5a1ea586b4d99a8e3028d51899b921acca484648 Mon Sep 17 00:00:00 2001 From: Divy Srivastava Date: Thu, 6 Oct 2022 20:51:08 -0700 Subject: refactor(napi): simplify `napi_value` interface (#16170) --- cli/napi/threadsafe_functions.rs | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) (limited to 'cli/napi/threadsafe_functions.rs') diff --git a/cli/napi/threadsafe_functions.rs b/cli/napi/threadsafe_functions.rs index 5374b6159..1a9704dbe 100644 --- a/cli/napi/threadsafe_functions.rs +++ b/cli/napi/threadsafe_functions.rs @@ -49,22 +49,12 @@ impl TsFn { let func: v8::Local = func.open(scope).to_object(scope).unwrap().into(); unsafe { - call_js_cb( - env as *mut c_void, - transmute::, napi_value>(func), - context, - data, - ) + call_js_cb(env as *mut c_void, func.into(), context, data) }; } None => { unsafe { - call_js_cb( - env as *mut c_void, - std::ptr::null_mut(), - context, - data, - ) + call_js_cb(env as *mut c_void, std::mem::zeroed(), context, data) }; } } @@ -110,9 +100,7 @@ fn napi_create_threadsafe_function( return Err(Error::InvalidArg); } let maybe_func = func - .as_mut() - .map(|func| { - let value = transmute::>(func); + .map(|value| { let func = v8::Local::::try_from(value) .map_err(|_| Error::FunctionExpected)?; Ok(v8::Global::new(&mut env_ref.scope(), func)) -- cgit v1.2.3