From f698bc70e2f1d4cd58d17544258cf1b19726b66a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Mon, 6 May 2024 20:22:50 +0100 Subject: fix(ext/node): napi_get_element and napi_set_element work with objects (#23713) This change makes DuckDB example work: https://github.com/denoland/deno/issues/23656. --- cli/napi/js_native_api.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'cli/napi/js_native_api.rs') diff --git a/cli/napi/js_native_api.rs b/cli/napi/js_native_api.rs index 126f2109c..428c4a04a 100644 --- a/cli/napi/js_native_api.rs +++ b/cli/napi/js_native_api.rs @@ -1855,11 +1855,11 @@ fn napi_get_element( check_env!(env); let env = unsafe { &mut *env }; let object = napi_value_unchecked(object); - let Ok(array) = v8::Local::::try_from(object) else { + let Ok(object) = v8::Local::::try_from(object) else { return napi_invalid_arg; }; let value: v8::Local = - array.get_index(&mut env.scope(), index).unwrap(); + object.get_index(&mut env.scope(), index).unwrap(); *result = value.into(); napi_ok } @@ -2521,11 +2521,11 @@ fn napi_set_element( check_env!(env); let env = unsafe { &mut *env }; let object = napi_value_unchecked(object); - let Ok(array) = v8::Local::::try_from(object) else { + let Ok(object) = v8::Local::::try_from(object) else { return napi_invalid_arg; }; let value = napi_value_unchecked(value); - array.set_index(&mut env.scope(), index, value).unwrap(); + object.set_index(&mut env.scope(), index, value).unwrap(); napi_ok } -- cgit v1.2.3