From b5ce9cda0dfaed4afcb85d71c2c49c82b2fe3401 Mon Sep 17 00:00:00 2001 From: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> Date: Fri, 19 Apr 2024 10:11:17 -0700 Subject: perf(lsp): Avoid passing struct into op_resolve (#23452) Going through serde_v8 is slow, so just pass the args separately. `op_resolve` is especially hot, so any speedups are good. --- cli/lsp/tsc.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'cli/lsp') diff --git a/cli/lsp/tsc.rs b/cli/lsp/tsc.rs index 5b1136d90..16cca30e1 100644 --- a/cli/lsp/tsc.rs +++ b/cli/lsp/tsc.rs @@ -4058,9 +4058,10 @@ fn op_release( #[serde] fn op_resolve( state: &mut OpState, - #[serde] args: ResolveArgs, + #[string] base: String, + #[serde] specifiers: Vec, ) -> Result>, AnyError> { - op_resolve_inner(state, args) + op_resolve_inner(state, ResolveArgs { base, specifiers }) } #[inline] -- cgit v1.2.3