From 98bbf87742969802b392130c536454aa61a20395 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Fri, 30 Dec 2022 14:11:50 +0100 Subject: fix(lsp): less agressive completion triggers (#17225) Closes https://github.com/denoland/deno/issues/17056 Closes https://github.com/denoland/deno/issues/17055 --- cli/lsp/tsc.rs | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'cli/lsp') diff --git a/cli/lsp/tsc.rs b/cli/lsp/tsc.rs index 7145d00c2..8a83839bf 100644 --- a/cli/lsp/tsc.rs +++ b/cli/lsp/tsc.rs @@ -2007,6 +2007,10 @@ impl CompletionEntryDetails { documentation, command, additional_text_edits, + // NOTE(bartlomieju): it's not entirely clear to me why we need to do that, + // but when `completionItem/resolve` is called, we get a list of commit chars + // even though we might have returned an empty list in `completion` request. + commit_characters: None, ..original_item.clone() }) } -- cgit v1.2.3