From 2dc37f411e8947d3c20cd93d1fa1937edc239499 Mon Sep 17 00:00:00 2001 From: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> Date: Wed, 27 Mar 2024 14:14:27 -0700 Subject: feat(task): Task description in the form of comments (#23101) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Closes #22786. TLDR; ```jsonc { "tasks": { // Some comment // // describing what the task does "dev": "deno run -A --watch main.ts" } } ``` ```bash deno task ``` ![Screenshot 2024-03-27 at 1 43 49 PM](https://github.com/denoland/deno/assets/17734409/7a14da8c-8e63-45ba-9bfb-590d250b56a9) --- cli/lsp/config.rs | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) (limited to 'cli/lsp/config.rs') diff --git a/cli/lsp/config.rs b/cli/lsp/config.rs index 5fa2a00a6..304a53b8b 100644 --- a/cli/lsp/config.rs +++ b/cli/lsp/config.rs @@ -1136,7 +1136,10 @@ impl ConfigData { file_fetcher: Option<&FileFetcher>, ) -> Self { if let Some(specifier) = config_file_specifier { - match ConfigFile::from_specifier(specifier.clone()) { + match ConfigFile::from_specifier( + specifier.clone(), + &deno_config::ParseOptions::default(), + ) { Ok(config_file) => { lsp_log!( " Resolved Deno configuration file: \"{}\"", @@ -1949,7 +1952,12 @@ mod tests { config .tree .inject_config_file( - ConfigFile::new("{}", root_uri.join("deno.json").unwrap()).unwrap(), + ConfigFile::new( + "{}", + root_uri.join("deno.json").unwrap(), + &deno_config::ParseOptions::default(), + ) + .unwrap(), ) .await; assert!(config.specifier_enabled(&root_uri)); @@ -1996,6 +2004,7 @@ mod tests { }) .to_string(), root_uri.join("deno.json").unwrap(), + &deno_config::ParseOptions::default(), ) .unwrap(), ) @@ -2021,6 +2030,7 @@ mod tests { }) .to_string(), root_uri.join("deno.json").unwrap(), + &deno_config::ParseOptions::default(), ) .unwrap(), ) @@ -2038,6 +2048,7 @@ mod tests { }) .to_string(), root_uri.join("deno.json").unwrap(), + &deno_config::ParseOptions::default(), ) .unwrap(), ) @@ -2067,6 +2078,7 @@ mod tests { }) .to_string(), root_uri.join("deno.json").unwrap(), + &deno_config::ParseOptions::default(), ) .unwrap(), ) -- cgit v1.2.3