From 0dd131d4a512e8e8370b571d6801eabb4cb30e58 Mon Sep 17 00:00:00 2001 From: dubiousjim Date: Sat, 7 Mar 2020 22:29:12 -0500 Subject: Rename perm to mode (#4276) There's a lot of variation in doc comments and internal code about whether chmod/0o777-style permissions are called `mode` or `perm`. (For example, mkdir and writeFile choose differently.) Had proposed earlier to go consistently with `perm`, but on balance devs prefer to go with `mode`. --- cli/js/write_file_test.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'cli/js/write_file_test.ts') diff --git a/cli/js/write_file_test.ts b/cli/js/write_file_test.ts index 692290938..c06c5b330 100644 --- a/cli/js/write_file_test.ts +++ b/cli/js/write_file_test.ts @@ -47,14 +47,14 @@ unitTest({ perms: { write: false } }, function writeFileSyncPerm(): void { unitTest( { perms: { read: true, write: true } }, - function writeFileSyncUpdatePerm(): void { + function writeFileSyncUpdateMode(): void { if (Deno.build.os !== "win") { const enc = new TextEncoder(); const data = enc.encode("Hello"); const filename = Deno.makeTempDirSync() + "/test.txt"; - Deno.writeFileSync(filename, data, { perm: 0o755 }); + Deno.writeFileSync(filename, data, { mode: 0o755 }); assertEquals(Deno.statSync(filename).mode! & 0o777, 0o755); - Deno.writeFileSync(filename, data, { perm: 0o666 }); + Deno.writeFileSync(filename, data, { mode: 0o666 }); assertEquals(Deno.statSync(filename).mode! & 0o777, 0o666); } } @@ -163,14 +163,14 @@ unitTest( unitTest( { perms: { read: true, write: true } }, - async function writeFileUpdatePerm(): Promise { + async function writeFileUpdateMode(): Promise { if (Deno.build.os !== "win") { const enc = new TextEncoder(); const data = enc.encode("Hello"); const filename = Deno.makeTempDirSync() + "/test.txt"; - await Deno.writeFile(filename, data, { perm: 0o755 }); + await Deno.writeFile(filename, data, { mode: 0o755 }); assertEquals(Deno.statSync(filename).mode! & 0o777, 0o755); - await Deno.writeFile(filename, data, { perm: 0o666 }); + await Deno.writeFile(filename, data, { mode: 0o666 }); assertEquals(Deno.statSync(filename).mode! & 0o777, 0o666); } } -- cgit v1.2.3