From fc4819e1e0624b9377913932202bc31f5a25bab4 Mon Sep 17 00:00:00 2001
From: Kitson Kelly <me@kitsonkelly.com>
Date: Sun, 12 Apr 2020 01:42:02 +1000
Subject: refactor: Event and EventTarget implementations (#4707)

Refactors Event and EventTarget so that they better encapsulate their
non-public data as well as are more forward compatible with things like
DOM Nodes.

Moves `dom_types.ts` -> `dom_types.d.ts` which was always the intention,
it was a legacy of when we used to build the types from the code and the
limitations of the compiler.  There was a lot of cruft in `dom_types`
which shouldn't have been there, and mis-alignment to the DOM standards.
This generally has been eliminated, though we still have some minor
differences from the DOM (like the removal of some deprecated
methods/properties).

Adds `DOMException`.  Strictly it shouldn't inherit from `Error`, but
most browsers provide a stack trace when one is thrown, so the behaviour
in Deno actually better matches the browser.

`Event` still doesn't log to console like it does in the browser.  I
 wanted to get this raised and that could be an enhancement later on (it
 currently doesn't either).
---
 cli/js/tests/dom_exception_test.ts |  9 +++++++++
 cli/js/tests/event_target_test.ts  | 12 ------------
 cli/js/tests/event_test.ts         |  2 --
 cli/js/tests/unit_tests.ts         |  1 +
 4 files changed, 10 insertions(+), 14 deletions(-)
 create mode 100644 cli/js/tests/dom_exception_test.ts

(limited to 'cli/js/tests')

diff --git a/cli/js/tests/dom_exception_test.ts b/cli/js/tests/dom_exception_test.ts
new file mode 100644
index 000000000..2eb7633e1
--- /dev/null
+++ b/cli/js/tests/dom_exception_test.ts
@@ -0,0 +1,9 @@
+// Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.
+import { unitTest, assertEquals, assert } from "./test_util.ts";
+
+unitTest(function testDomError() {
+  const de = new DOMException("foo", "bar");
+  assert(de);
+  assertEquals(de.message, "foo");
+  assertEquals(de.name, "bar");
+});
diff --git a/cli/js/tests/event_target_test.ts b/cli/js/tests/event_target_test.ts
index ece4b5dba..0c4eb4d0d 100644
--- a/cli/js/tests/event_target_test.ts
+++ b/cli/js/tests/event_target_test.ts
@@ -35,18 +35,6 @@ unitTest(function constructedEventTargetCanBeUsedAsExpected(): void {
   assertEquals(callCount, 2);
 });
 
-// TODO(ry) Should AddEventListenerOptions and EventListenerOptions be exposed
-// from the public API?
-
-interface AddEventListenerOptions extends EventListenerOptions {
-  once?: boolean;
-  passive?: boolean;
-}
-
-interface EventListenerOptions {
-  capture?: boolean;
-}
-
 unitTest(function anEventTargetCanBeSubclassed(): void {
   class NicerEventTarget extends EventTarget {
     on(
diff --git a/cli/js/tests/event_test.ts b/cli/js/tests/event_test.ts
index 05a9ed577..ce3076e58 100644
--- a/cli/js/tests/event_test.ts
+++ b/cli/js/tests/event_test.ts
@@ -48,10 +48,8 @@ unitTest(function eventStopImmediatePropagationSuccess(): void {
   const event = new Event(type);
 
   assertEquals(event.cancelBubble, false);
-  assertEquals(event.cancelBubbleImmediately, false);
   event.stopImmediatePropagation();
   assertEquals(event.cancelBubble, true);
-  assertEquals(event.cancelBubbleImmediately, true);
 });
 
 unitTest(function eventPreventDefaultSuccess(): void {
diff --git a/cli/js/tests/unit_tests.ts b/cli/js/tests/unit_tests.ts
index 4cff3d1d8..ba3d6746a 100644
--- a/cli/js/tests/unit_tests.ts
+++ b/cli/js/tests/unit_tests.ts
@@ -16,6 +16,7 @@ import "./custom_event_test.ts";
 import "./dir_test.ts";
 import "./dispatch_minimal_test.ts";
 import "./dispatch_json_test.ts";
+import "./dom_exception_test.ts";
 import "./error_stack_test.ts";
 import "./event_test.ts";
 import "./event_target_test.ts";
-- 
cgit v1.2.3