From fc4819e1e0624b9377913932202bc31f5a25bab4 Mon Sep 17 00:00:00 2001 From: Kitson Kelly Date: Sun, 12 Apr 2020 01:42:02 +1000 Subject: refactor: Event and EventTarget implementations (#4707) Refactors Event and EventTarget so that they better encapsulate their non-public data as well as are more forward compatible with things like DOM Nodes. Moves `dom_types.ts` -> `dom_types.d.ts` which was always the intention, it was a legacy of when we used to build the types from the code and the limitations of the compiler. There was a lot of cruft in `dom_types` which shouldn't have been there, and mis-alignment to the DOM standards. This generally has been eliminated, though we still have some minor differences from the DOM (like the removal of some deprecated methods/properties). Adds `DOMException`. Strictly it shouldn't inherit from `Error`, but most browsers provide a stack trace when one is thrown, so the behaviour in Deno actually better matches the browser. `Event` still doesn't log to console like it does in the browser. I wanted to get this raised and that could be an enhancement later on (it currently doesn't either). --- cli/js/tests/dom_exception_test.ts | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 cli/js/tests/dom_exception_test.ts (limited to 'cli/js/tests/dom_exception_test.ts') diff --git a/cli/js/tests/dom_exception_test.ts b/cli/js/tests/dom_exception_test.ts new file mode 100644 index 000000000..2eb7633e1 --- /dev/null +++ b/cli/js/tests/dom_exception_test.ts @@ -0,0 +1,9 @@ +// Copyright 2018-2020 the Deno authors. All rights reserved. MIT license. +import { unitTest, assertEquals, assert } from "./test_util.ts"; + +unitTest(function testDomError() { + const de = new DOMException("foo", "bar"); + assert(de); + assertEquals(de.message, "foo"); + assertEquals(de.name, "bar"); +}); -- cgit v1.2.3