From 8d96dffa410a149d0fff6115bd97f41fc1fe7459 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= <biwanczuk@gmail.com>
Date: Wed, 4 Mar 2020 17:31:14 +0100
Subject: refactor: rewrite testPerm into unitTest (#4231)

Rewrite "testPerm" helper function used for testing of internal
runtime code. It's been renamed to "unitTest" and provides API that
is extensible in the future by accepting optional "UnitTestOptions"
argument. "test" helper was also removed and replaced by
overloaded version of "unitTest" that takes only function argument.

"UnitTestOptions" currently supports "perms" and "skip"
options, where former works exactly as first argument to "testPerm"
did, while the latter allows to conditionally skip tests.
---
 cli/js/read_dir_test.ts | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

(limited to 'cli/js/read_dir_test.ts')

diff --git a/cli/js/read_dir_test.ts b/cli/js/read_dir_test.ts
index 97a2e871a..6df4373cf 100644
--- a/cli/js/read_dir_test.ts
+++ b/cli/js/read_dir_test.ts
@@ -1,5 +1,5 @@
 // Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.
-import { testPerm, assert, assertEquals } from "./test_util.ts";
+import { unitTest, assert, assertEquals } from "./test_util.ts";
 
 type FileInfo = Deno.FileInfo;
 
@@ -21,12 +21,12 @@ function assertSameContent(files: FileInfo[]): void {
   assertEquals(counter, 2);
 }
 
-testPerm({ read: true }, function readDirSyncSuccess(): void {
+unitTest({ perms: { read: true } }, function readDirSyncSuccess(): void {
   const files = Deno.readDirSync("cli/tests/");
   assertSameContent(files);
 });
 
-testPerm({ read: false }, function readDirSyncPerm(): void {
+unitTest({ perms: { read: false } }, function readDirSyncPerm(): void {
   let caughtError = false;
   try {
     Deno.readDirSync("tests/");
@@ -37,7 +37,7 @@ testPerm({ read: false }, function readDirSyncPerm(): void {
   assert(caughtError);
 });
 
-testPerm({ read: true }, function readDirSyncNotDir(): void {
+unitTest({ perms: { read: true } }, function readDirSyncNotDir(): void {
   let caughtError = false;
   let src;
 
@@ -51,7 +51,7 @@ testPerm({ read: true }, function readDirSyncNotDir(): void {
   assertEquals(src, undefined);
 });
 
-testPerm({ read: true }, function readDirSyncNotFound(): void {
+unitTest({ perms: { read: true } }, function readDirSyncNotFound(): void {
   let caughtError = false;
   let src;
 
@@ -65,12 +65,16 @@ testPerm({ read: true }, function readDirSyncNotFound(): void {
   assertEquals(src, undefined);
 });
 
-testPerm({ read: true }, async function readDirSuccess(): Promise<void> {
+unitTest({ perms: { read: true } }, async function readDirSuccess(): Promise<
+  void
+> {
   const files = await Deno.readDir("cli/tests/");
   assertSameContent(files);
 });
 
-testPerm({ read: false }, async function readDirPerm(): Promise<void> {
+unitTest({ perms: { read: false } }, async function readDirPerm(): Promise<
+  void
+> {
   let caughtError = false;
   try {
     await Deno.readDir("tests/");
-- 
cgit v1.2.3