From ee452ad883c1c711839655a307b39e8eea5bf410 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Tue, 3 Mar 2020 18:22:53 +0100 Subject: add assertOps sanitizer in cli/js/ unit tests (#4209) * add "assertOps" test assertion which makes sure test case is not "leaking" ops - ie. after test finishes there are no pending async ops * apply "assertOps" to all tests in "cli/js/" * fix numerous tests leaking ops * document problem with edge case in "clearInterval" and "clearTimeout" implementation where they may leak async ops * move "cli/js/worker_test.ts" to "cli/tests/worker_test.ts" and run as integration test; workers leak ops because of missing "terminate" implementation --- cli/js/net_test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'cli/js/net_test.ts') diff --git a/cli/js/net_test.ts b/cli/js/net_test.ts index 8a53a1c74..41d012c56 100644 --- a/cli/js/net_test.ts +++ b/cli/js/net_test.ts @@ -54,7 +54,7 @@ testPerm({ net: true }, async function netTcpConcurrentAccept(): Promise { const p1 = listener.accept().catch(checkErr); await Promise.race([p, p1]); listener.close(); - await [p, p1]; + await Promise.all([p, p1]); assertEquals(acceptErrCount, 1); }); -- cgit v1.2.3