From 0dd131d4a512e8e8370b571d6801eabb4cb30e58 Mon Sep 17 00:00:00 2001 From: dubiousjim Date: Sat, 7 Mar 2020 22:29:12 -0500 Subject: Rename perm to mode (#4276) There's a lot of variation in doc comments and internal code about whether chmod/0o777-style permissions are called `mode` or `perm`. (For example, mkdir and writeFile choose differently.) Had proposed earlier to go consistently with `perm`, but on balance devs prefer to go with `mode`. --- cli/js/chmod_test.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'cli/js/chmod_test.ts') diff --git a/cli/js/chmod_test.ts b/cli/js/chmod_test.ts index 9edc7afee..8731fad22 100644 --- a/cli/js/chmod_test.ts +++ b/cli/js/chmod_test.ts @@ -10,7 +10,7 @@ unitTest( const data = enc.encode("Hello"); const tempDir = Deno.makeTempDirSync(); const filename = tempDir + "/test.txt"; - Deno.writeFileSync(filename, data, { perm: 0o666 }); + Deno.writeFileSync(filename, data, { mode: 0o666 }); // On windows no effect, but should not crash Deno.chmodSync(filename, 0o777); @@ -36,7 +36,7 @@ unitTest( const tempDir = Deno.makeTempDirSync(); const filename = tempDir + "/test.txt"; - Deno.writeFileSync(filename, data, { perm: 0o666 }); + Deno.writeFileSync(filename, data, { mode: 0o666 }); const symlinkName = tempDir + "/test_symlink.txt"; Deno.symlinkSync(filename, symlinkName); @@ -85,7 +85,7 @@ unitTest( const data = enc.encode("Hello"); const tempDir = Deno.makeTempDirSync(); const filename = tempDir + "/test.txt"; - Deno.writeFileSync(filename, data, { perm: 0o666 }); + Deno.writeFileSync(filename, data, { mode: 0o666 }); // On windows no effect, but should not crash await Deno.chmod(filename, 0o777); @@ -112,7 +112,7 @@ unitTest( const tempDir = Deno.makeTempDirSync(); const filename = tempDir + "/test.txt"; - Deno.writeFileSync(filename, data, { perm: 0o666 }); + Deno.writeFileSync(filename, data, { mode: 0o666 }); const symlinkName = tempDir + "/test_symlink.txt"; Deno.symlinkSync(filename, symlinkName); -- cgit v1.2.3