From b40086fd7da3729d1d59b312c89ee57747fc66a9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= <biwanczuk@gmail.com>
Date: Sat, 4 Mar 2023 22:31:38 -0400
Subject: refactor(core): include_js_files! 'dir' option doesn't change
 specifiers (#18019)

This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten
to include it.

Example:
```
include_js_files! {
  dir "js",
  "hello.js",
}
```

The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`.
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in:
`import ... from "internal:<ext_name>/hello.js"`.

The directory the files are stored in, is an implementation detail and
in some cases might result in a significant size difference for the
snapshot. As an example, in "deno_node" extension, we store the
source code in "polyfills" directory; which resulted in each specifier
to look like "internal:deno_node/polyfills/<module_name>", but with
this change it's "internal:deno_node/<module_name>".

Given that "deno_node" has over 100 files, many of them having
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
---
 cli/js/40_testing.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'cli/js/40_testing.js')

diff --git a/cli/js/40_testing.js b/cli/js/40_testing.js
index 7ea52a5fc..5077af120 100644
--- a/cli/js/40_testing.js
+++ b/cli/js/40_testing.js
@@ -3,9 +3,9 @@
 const core = globalThis.Deno.core;
 const ops = core.ops;
 const internals = globalThis.__bootstrap.internals;
-import { setExitHandler } from "internal:runtime/js/30_os.js";
+import { setExitHandler } from "internal:runtime/30_os.js";
 import { Console } from "internal:deno_console/02_console.js";
-import { serializePermissions } from "internal:runtime/js/10_permissions.js";
+import { serializePermissions } from "internal:runtime/10_permissions.js";
 import { assert } from "internal:deno_web/00_infra.js";
 const primordials = globalThis.__bootstrap.primordials;
 const {
@@ -1424,6 +1424,6 @@ internals.testing = {
   enableBench,
 };
 
-import { denoNs } from "internal:runtime/js/90_deno_ns.js";
+import { denoNs } from "internal:runtime/90_deno_ns.js";
 denoNs.bench = bench;
 denoNs.test = test;
-- 
cgit v1.2.3