From 36e6e4a00997603d2290c416239c2de8feeb6ede Mon Sep 17 00:00:00 2001
From: David Sherret <dsherret@users.noreply.github.com>
Date: Fri, 15 Mar 2024 09:57:24 -0400
Subject: fix: handle cache body file not existing when using etag (#22931)

---
 cli/file_fetcher.rs | 22 +++++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

(limited to 'cli/file_fetcher.rs')

diff --git a/cli/file_fetcher.rs b/cli/file_fetcher.rs
index a74a14a3f..3808d68ce 100644
--- a/cli/file_fetcher.rs
+++ b/cli/file_fetcher.rs
@@ -14,6 +14,7 @@ use crate::util::progress_bar::ProgressBar;
 use crate::util::progress_bar::UpdateGuard;
 
 use deno_ast::MediaType;
+use deno_core::anyhow::bail;
 use deno_core::anyhow::Context;
 use deno_core::error::custom_error;
 use deno_core::error::generic_error;
@@ -372,6 +373,7 @@ impl FileFetcher {
     }
 
     async move {
+      let mut maybe_etag = maybe_etag;
       let mut retried = false;
       let result = loop {
         let result = match fetch_once(
@@ -388,9 +390,23 @@ impl FileFetcher {
         {
           FetchOnceResult::NotModified => {
             let file = file_fetcher
-              .fetch_cached(&specifier, maybe_checksum, 10)?
-              .unwrap();
-            Ok(file)
+              .fetch_cached(&specifier, maybe_checksum.clone(), 10)?;
+            match file {
+              Some(file) => Ok(file),
+              None => {
+                // Someone may have deleted the body from the cache since
+                // it's currently stored in a separate file from the headers,
+                // so delete the etag and try again
+                if maybe_etag.is_some() {
+                  debug!("Cache body not found. Trying again without etag.");
+                  maybe_etag = None;
+                  continue;
+                } else {
+                  // should never happen
+                  bail!("Your deno cache directory is in an unrecoverable state. Please delete it and try again.")
+                }
+              }
+            }
           }
           FetchOnceResult::Redirect(redirect_url, headers) => {
             file_fetcher.http_cache.set(&specifier, headers, &[])?;
-- 
cgit v1.2.3