From 52b96fc22a93c804702617f20d24ed115fd5a780 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Thu, 5 Mar 2020 11:13:10 +0100 Subject: refactor: cleanup compiler runtimes (#4230) - Cleanup "tsCompilerOnMessage" by factoring out separate methods for each request type: * "compile" * "runtimeCompile" * "runtimeTranspile" - Simplify control flow of compiler workers by a) no longer calling "close()" in worker runtime after a single message; b) explicitly shutting down worker from host after a single message Co-authored-by: Ryan Dahl --- cli/compilers/wasm.rs | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'cli/compilers/wasm.rs') diff --git a/cli/compilers/wasm.rs b/cli/compilers/wasm.rs index bcdc8a51c..bd22a2523 100644 --- a/cli/compilers/wasm.rs +++ b/cli/compilers/wasm.rs @@ -134,11 +134,7 @@ async fn execute_in_thread( WorkerEvent::Message(buf) => Ok(buf), WorkerEvent::Error(error) => Err(error), }?; - // Compiler worker finishes after one request - // so we should receive signal that channel was closed. - // Then close worker's channel and join the thread. - let event = handle.get_event().await; - assert!(event.is_none()); + // Shutdown worker and wait for thread to finish handle.sender.close_channel(); join_handle.join().unwrap(); Ok(buf) -- cgit v1.2.3