From f7c298e2972e6a1eb8f9329272ed8e8c9549266c Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Mon, 26 Apr 2021 13:28:38 -0400 Subject: Remove denort optimization (#10350) denort is an optimization to "deno compile" to produce slightly smaller output. It's a decent idea, but causes a lot of negative side-effects: - Deno's link time is a source of constant agony both locally and in CI, denort doubles link time. - The release process is a long and arduous undertaking with many manual steps. denort necessitates an additional manual zip + upload from M1 apple computers. - The "deno compile" interface is complicated with the "--lite" option. This is confusing for uses ("why wouldn't you want lite?"). The benefits of this feature do not outweigh the negatives. We must find a different approach to optimizing "deno compile" output. --- cli/bench/main.rs | 6 ------ 1 file changed, 6 deletions(-) (limited to 'cli/bench') diff --git a/cli/bench/main.rs b/cli/bench/main.rs index 8890ec79c..f2ade54d8 100644 --- a/cli/bench/main.rs +++ b/cli/bench/main.rs @@ -228,12 +228,6 @@ fn get_binary_sizes(target_dir: &Path) -> Result> { test_util::deno_exe_path().metadata()?.len(), ); - // add up size for denort - sizes.insert( - "denort".to_string(), - test_util::denort_exe_path().metadata()?.len(), - ); - // add up size for everything in target/release/deps/libswc* let swc_size = rlib_size(&target_dir, "libswc"); println!("swc {} bytes", swc_size); -- cgit v1.2.3