From 2164f6b1eb7216c1045d547c94f26fe3ceaa9403 Mon Sep 17 00:00:00 2001 From: Aapo Alasuutari Date: Thu, 11 Aug 2022 16:56:56 +0300 Subject: perf(ops): Monomorphic sync op calls (#15337) Welcome to better optimised op calls! Currently opSync is called with parameters of every type and count. This most definitely makes the call megamorphic. Additionally, it seems that spread params leads to V8 not being able to optimise the calls quite as well (apparently Fast Calls cannot be used with spread params). Monomorphising op calls should lead to some improved performance. Now that unwrapping of sync ops results is done on Rust side, this is pretty simple: ``` opSync("op_foo", param1, param2); // -> turns to ops.op_foo(param1, param2); ``` This means sync op calls are now just directly calling the native binding function. When V8 Fast API Calls are enabled, this will enable those to be called on the optimised path. Monomorphising async ops likely requires using callbacks and is left as an exercise to the reader. --- cli/bench/deno_common.js | 6 +++++- cli/bench/http/deno_http_ops.js | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) (limited to 'cli/bench') diff --git a/cli/bench/deno_common.js b/cli/bench/deno_common.js index c31ccd981..abafdc519 100644 --- a/cli/bench/deno_common.js +++ b/cli/bench/deno_common.js @@ -6,7 +6,11 @@ Deno.bench("date_now", { n: 5e5 }, () => { }); // Void ops measure op-overhead -Deno.bench("op_void_sync", { n: 1e7 }, () => Deno.core.opSync("op_void_sync")); +Deno.bench( + "op_void_sync", + { n: 1e7 }, + () => Deno.core.ops.op_void_sync(), +); Deno.bench( "op_void_async", diff --git a/cli/bench/http/deno_http_ops.js b/cli/bench/http/deno_http_ops.js index aac5cea72..f65b32170 100644 --- a/cli/bench/http/deno_http_ops.js +++ b/cli/bench/http/deno_http_ops.js @@ -19,7 +19,7 @@ class Http { } for await (const conn of tcp) { - const id = Deno.core.opSync("op_http_start", conn.rid); + const id = Deno.core.ops.op_http_start(conn.rid); const http = new Http(id); (async () => { for await (const req of http) { -- cgit v1.2.3