From 4ef08a58dfbcf893f25fd59917aa946f455e85f2 Mon Sep 17 00:00:00 2001
From: Luca Casonato <hello@lcas.dev>
Date: Wed, 24 Aug 2022 00:08:56 +0200
Subject: feat: update `Deno.serve` function signature (#15563)

This commit changes the `Deno.serve` function signature to be more
versatile and easier to use. It is now a drop in replacement for
std/http's `serve`.

The input validation has also been reworked.
---
 cli/bench/http/deno_flash_hono_router.js   |  2 +-
 cli/bench/http/deno_flash_send_file.js     |  4 ++--
 cli/bench/http/deno_http_flash.js          |  8 ++------
 cli/bench/http/deno_reactdom_ssr_flash.jsx | 12 +++---------
 4 files changed, 8 insertions(+), 18 deletions(-)

(limited to 'cli/bench/http')

diff --git a/cli/bench/http/deno_flash_hono_router.js b/cli/bench/http/deno_flash_hono_router.js
index 4c3336c63..af6adc9ba 100644
--- a/cli/bench/http/deno_flash_hono_router.js
+++ b/cli/bench/http/deno_flash_hono_router.js
@@ -7,4 +7,4 @@ const [hostname, port] = addr.split(":");
 const app = new Hono();
 app.get("/", (c) => c.text("Hello, World!"));
 
-Deno.serve({ fetch: app.fetch, port: Number(port), hostname });
+Deno.serve(app.fetch, { port: Number(port), hostname });
diff --git a/cli/bench/http/deno_flash_send_file.js b/cli/bench/http/deno_flash_send_file.js
index 81e8c4991..db2ad7a82 100644
--- a/cli/bench/http/deno_flash_send_file.js
+++ b/cli/bench/http/deno_flash_send_file.js
@@ -6,9 +6,9 @@ const { serve } = Deno;
 
 const path = new URL("../testdata/128k.bin", import.meta.url).pathname;
 
-function fetch() {
+function handler() {
   const file = Deno.openSync(path);
   return new Response(file.readable);
 }
 
-serve({ fetch, hostname, port: Number(port) });
+serve(handler, { hostname, port: Number(port) });
diff --git a/cli/bench/http/deno_http_flash.js b/cli/bench/http/deno_http_flash.js
index 3823bb9cd..7c486f422 100644
--- a/cli/bench/http/deno_http_flash.js
+++ b/cli/bench/http/deno_http_flash.js
@@ -4,12 +4,8 @@ const addr = Deno.args[0] || "127.0.0.1:4500";
 const [hostname, port] = addr.split(":");
 const { serve } = Deno;
 
-function fetch() {
+function handler() {
   return new Response("Hello World");
 }
 
-serve({
-  fetch,
-  hostname,
-  port,
-});
+serve(handler, { hostname, port });
diff --git a/cli/bench/http/deno_reactdom_ssr_flash.jsx b/cli/bench/http/deno_reactdom_ssr_flash.jsx
index 0d749c634..42c955624 100644
--- a/cli/bench/http/deno_reactdom_ssr_flash.jsx
+++ b/cli/bench/http/deno_reactdom_ssr_flash.jsx
@@ -18,12 +18,6 @@ const headers = {
   },
 };
 
-serve(
-  {
-    fetch: async () => {
-      return new Response(await renderToReadableStream(<App />), headers);
-    },
-    hostname,
-    port,
-  },
-);
+serve({ hostname, port }, async () => {
+  return new Response(await renderToReadableStream(<App />), headers);
+});
-- 
cgit v1.2.3