From f358ae627843182fb6aad69dae74f6d29788956b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Fri, 12 Apr 2024 00:17:10 +0100 Subject: fix(inspector): don't panic if port is not free (#22745) Closes https://github.com/denoland/deno/issues/22113 Closes https://github.com/denoland/deno/issues/23177 Closes https://github.com/denoland/deno/issues/22883 Closes https://github.com/denoland/deno/issues/22377 --- cli/args/mod.rs | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) (limited to 'cli/args') diff --git a/cli/args/mod.rs b/cli/args/mod.rs index d225b73f2..9bc409307 100644 --- a/cli/args/mod.rs +++ b/cli/args/mod.rs @@ -1186,14 +1186,20 @@ impl CliOptions { } } - pub fn resolve_inspector_server(&self) -> Option { + pub fn resolve_inspector_server( + &self, + ) -> Result, AnyError> { let maybe_inspect_host = self .flags .inspect .or(self.flags.inspect_brk) .or(self.flags.inspect_wait); - maybe_inspect_host - .map(|host| InspectorServer::new(host, version::get_user_agent())) + + let Some(host) = maybe_inspect_host else { + return Ok(None); + }; + + Ok(Some(InspectorServer::new(host, version::get_user_agent())?)) } pub fn maybe_lockfile(&self) -> Option>> { -- cgit v1.2.3