From 275dee60e71225a9c6c4b3b4ea7ffe4c6ecb4d87 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Thu, 23 Mar 2023 23:27:58 +0100 Subject: refactor: make version and user_agent &'static str (#18400) These caused a bunch of unnecessary allocations on each startup. --- cli/args/flags.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'cli/args') diff --git a/cli/args/flags.rs b/cli/args/flags.rs index 236352f24..e85938822 100644 --- a/cli/args/flags.rs +++ b/cli/args/flags.rs @@ -641,7 +641,7 @@ To evaluate code in the shell: /// Main entry point for parsing deno's command line flags. pub fn flags_from_vec(args: Vec) -> clap::Result { let version = crate::version::deno(); - let mut app = clap_root(&version); + let mut app = clap_root(version); let matches = app.try_get_matches_from_mut(&args)?; let mut flags = Flags::default(); @@ -712,7 +712,7 @@ fn handle_repl_flags(flags: &mut Flags, repl_flags: ReplFlags) { flags.subcommand = DenoSubcommand::Repl(repl_flags); } -fn clap_root(version: &str) -> Command { +fn clap_root(version: &'static str) -> Command { clap::Command::new("deno") .bin_name("deno") .color(ColorChoice::Never) -- cgit v1.2.3