From f5c31b56e3fb57a92dbaaec17690bfa9d787164e Mon Sep 17 00:00:00 2001 From: Aaron O'Mullan Date: Sun, 15 May 2022 13:27:56 +0200 Subject: Revert "core: don't include_str extension js code (#10786)" (#14614) This reverts commit 10e50a120744de71d6915af4ae93f8231607573d Alternative to #13217, IMO the tradeoffs made by #10786 aren't worth it. It breaks abstractions (crates being self-contained, deno_core without snapshotting etc...) and causes pain points / gotchas for both embedders & devs for a relatively minimal gain in incremental build time ... Closes #11030 --- bench_util/benches/utf8.rs | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) (limited to 'bench_util/benches/utf8.rs') diff --git a/bench_util/benches/utf8.rs b/bench_util/benches/utf8.rs index 021c409b8..499571e5e 100644 --- a/bench_util/benches/utf8.rs +++ b/bench_util/benches/utf8.rs @@ -9,19 +9,14 @@ fn setup() -> Vec { vec![Extension::builder() .js(vec![( "setup.js", - Box::new(|| { - Ok( - r#" + r#" const hello = "hello world\n"; const hello1k = hello.repeat(1e3); const hello1m = hello.repeat(1e6); const helloEncoded = Deno.core.encode(hello); const hello1kEncoded = Deno.core.encode(hello1k); const hello1mEncoded = Deno.core.encode(hello1m); - "# - .into(), - ) - }), + "#, )]) .build()] } -- cgit v1.2.3