From f911dc3afe521e018553d98bc904870817f5310f Mon Sep 17 00:00:00 2001 From: Bert Belder Date: Fri, 9 Oct 2020 14:42:03 +0200 Subject: ci: fix rusty_v8 binary download unavailable (#7898) A recent change in rustc or cargo made it so that rusty_v8's `build.rs`, which is responsible for downloading `librusty_v8.a`, does not get rebuilt or re-run when its build output directory is restored from the Github Actions cache. However, rusty_v8's custom build script does not save the download to its build output directory; it puts the file in `target/debug|release/gn_out/obj` instead. To get CI going again we opted to add `target/*/gn_out` to the Github Actions cache. A more robust fix would be make rusty_v8 save the download to the cargo-designated output directory. --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 400b5c590..a381bb757 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -114,6 +114,7 @@ jobs: target/*/.* target/*/build target/*/deps + target/*/gn_out key: deno-${{ matrix.os }}-${{ matrix.kind }}-${{ hashFiles('Cargo.lock') }} restore-keys: | deno-${{ matrix.os }}-${{ matrix.kind }}- -- cgit v1.2.3