From d98be230230ab93602d1f48ea0bdf9ddc6b0302d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Thu, 29 Jun 2023 23:21:09 +0200 Subject: chore: upgrade rusty_v8 to 0.74.0 (#19633) --- Cargo.lock | 4 ++-- Cargo.toml | 2 +- core/ops.rs | 10 +++++++++- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 2a4389b30..e23d71f8a 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -5854,9 +5854,9 @@ dependencies = [ [[package]] name = "v8" -version = "0.73.0" +version = "0.74.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "e1bd3f04ba5065795dae6e3db668ff0b628920fbd2e39c1755e9b62d93660c3c" +checksum = "9169f27f3ac2bcbaed828e0d463a335faaa1b2e802d8e6b5066fb9c0d657fe73" dependencies = [ "bitflags 1.3.2", "fslock", diff --git a/Cargo.toml b/Cargo.toml index 7ae66685b..79fdafaef 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -41,7 +41,7 @@ license = "MIT" repository = "https://github.com/denoland/deno" [workspace.dependencies] -v8 = { version = "0.73.0", default-features = false } +v8 = { version = "0.74.0", default-features = false } deno_ast = { version = "0.27.0", features = ["transpiling"] } deno_core = { version = "0.191.0", path = "./core" } diff --git a/core/ops.rs b/core/ops.rs index 361fc3cb7..7d4bc1e7d 100644 --- a/core/ops.rs +++ b/core/ops.rs @@ -23,6 +23,7 @@ use std::rc::Weak; use std::sync::Arc; use v8::fast_api::CFunctionInfo; use v8::fast_api::CTypeInfo; +use v8::fast_api::Int64Representation; pub type PromiseId = i32; pub type OpId = u16; @@ -139,7 +140,14 @@ impl OpCtx { // SAFETY: all arguments are coming from the trait and they have // static lifetime let c_fn = unsafe { - CFunctionInfo::new(args.as_ptr(), fast_fn.args.len(), ret.as_ptr()) + CFunctionInfo::new( + args.as_ptr(), + fast_fn.args.len(), + ret.as_ptr(), + // TODO(bartlomieju): in the future we might want to change it + // to use BigInt representation. + Int64Representation::Number, + ) }; fast_fn_c_info = Some(c_fn); } -- cgit v1.2.3