From ca55a5d36efd947ba9e7c8e56baacfc8a0eba120 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Fri, 12 Feb 2021 16:10:24 -0500 Subject: linux release build should use ubuntu-18.04 (#9485) --- .github/workflows/ci.yml | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8065a03a9..5cd8ca8ed 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,14 +17,23 @@ jobs: kind: test_release - os: windows-2019 kind: test_release - - os: ${{ github.repository == 'denoland/deno' && 'ubuntu-latest' || 'ubuntu-18.04' }} - kind: test_release - - os: ${{ github.repository == 'denoland/deno' && 'ubuntu-latest' || 'ubuntu-18.04' }} - kind: test_debug - - os: ${{ github.repository == 'denoland/deno' && 'ubuntu-latest' || 'ubuntu-18.04' }} + - os: ${{ github.repository == 'denoland/deno' && 'ubuntu-latest-xl' || 'ubuntu-latest' }} kind: bench - - os: ${{ github.repository == 'denoland/deno' && 'ubuntu-latest' || 'ubuntu-18.04' }} + # TODO(ry) Ideally we could use ubuntu-latest-xl for lint but there's + # a bug with dprint that is preventing this from running. + - os: ubuntu-latest kind: lint + # TODO(ry) Ideally we would use ubuntu-latest-xl for test_debug too, + # but there are race conditions in our test we are working around by + # using the slower runner. + - os: ubuntu-latest + kind: test_debug + # Warning: Do not upgrade test_release to newer version of ubuntu + # runners. We need to link against older version of glibc in order to + # run on older systems. glibc in 20.04 is not compatible with 18.04. + # See #9484. + - os: ubuntu-18.04 + kind: test_release # Always run master branch builds to completion. This allows the cache to # stay mostly up-to-date in situations where a single job fails due to -- cgit v1.2.3