From 8fdd65556299efa58512467b4d19d2612441d376 Mon Sep 17 00:00:00 2001 From: Divy Srivastava Date: Tue, 20 Feb 2024 17:58:29 +0530 Subject: fix(ext/node): unimplemented code when not IPC child_process (#22488) Fixes https://github.com/denoland/deno/issues/22299 --- ext/node/polyfills/internal/child_process.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ext/node/polyfills/internal/child_process.ts b/ext/node/polyfills/internal/child_process.ts index 584f6af11..62de6a098 100644 --- a/ext/node/polyfills/internal/child_process.ts +++ b/ext/node/polyfills/internal/child_process.ts @@ -300,7 +300,9 @@ export class ChildProcess extends EventEmitter { } /* Cancel any pending IPC I/O */ - this.disconnect?.(); + if (this.implementsDisconnect) { + this.disconnect?.(); + } this.killed = true; this.signalCode = denoSignal; @@ -1148,6 +1150,7 @@ export function setupChannel(target, ipc) { target.emit("disconnect"); }); }; + target.implementsDisconnect = true; // Start reading messages from the channel. readLoop(); -- cgit v1.2.3