From 6c15dc3f061b1d3a5b014fdbf79686ce60c605d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Wed, 7 Feb 2024 04:44:51 +0100 Subject: chore: remove op_spawn_child test (#22314) This test is not needed because the op is not available to user code anymore. This brings number of ops exposed to user code down to 15. --- cli/tests/integration/run_tests.rs | 19 ------------------- cli/tests/unit/ops_test.ts | 2 +- runtime/js/99_main.js | 4 ---- 3 files changed, 1 insertion(+), 24 deletions(-) diff --git a/cli/tests/integration/run_tests.rs b/cli/tests/integration/run_tests.rs index 654854204..56eea9c8d 100644 --- a/cli/tests/integration/run_tests.rs +++ b/cli/tests/integration/run_tests.rs @@ -4761,25 +4761,6 @@ fn permission_prompt_strips_ansi_codes_and_control_chars() { console.expect("undefined"); console.write_line_raw(r#"const moveANSIStart = "\u001b[1000D";"#); console.expect("undefined"); - - console.write_line_raw( - r#"Deno[Deno.internal].core.ops.op_spawn_child({ - cmd: "cat", - args: ["file.txt"], - clearEnv: false, - cwd: undefined, - env: [], - uid: undefined, - gid: undefined, - stdin: "null", - stdout: "inherit", - stderr: "piped", - signal: undefined, - windowsRawArguments: false, -}, moveANSIUp + clearANSI + moveANSIStart + prompt)"#, - ); - - console.expect(r#"┌ ⚠️ Deno requests run access to "cat""#); }); } diff --git a/cli/tests/unit/ops_test.ts b/cli/tests/unit/ops_test.ts index aca0d655a..4a0daa0a5 100644 --- a/cli/tests/unit/ops_test.ts +++ b/cli/tests/unit/ops_test.ts @@ -1,6 +1,6 @@ // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license. -const EXPECTED_OP_COUNT = 16; +const EXPECTED_OP_COUNT = 15; Deno.test(function checkExposedOps() { // @ts-ignore TS doesn't allow to index with symbol diff --git a/runtime/js/99_main.js b/runtime/js/99_main.js index 8f8a36db8..965af460d 100644 --- a/runtime/js/99_main.js +++ b/runtime/js/99_main.js @@ -585,10 +585,6 @@ const NOT_IMPORTED_OPS = [ "op_set_exit_code", "op_napi_open", "op_npm_process_state", - - // TODO(bartlomieju): used in a regression test, but probably not needed - // anymore if ops are not user accessible. - "op_spawn_child", ]; function removeImportedOps() { -- cgit v1.2.3