From 28682a1d2c2601033fb524b37c2796d55f72f22b Mon Sep 17 00:00:00 2001 From: Jinho Bang Date: Tue, 16 Oct 2018 02:28:35 +0900 Subject: Fix a binary size regression This patch changes Jumbo build to use only in debug mode. --- .gn | 4 ---- tools/setup.py | 4 +++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/.gn b/.gn index 07070a11f..bebb5388f 100644 --- a/.gn +++ b/.gn @@ -32,10 +32,6 @@ default_args = { treat_warnings_as_errors = false rust_treat_warnings_as_errors = true - # Enable Jumbo build by default - # https://chromium.googlesource.com/chromium/src/+/master/docs/jumbo.md - use_jumbo_build = true - # https://cs.chromium.org/chromium/src/docs/ccache_mac.md clang_use_chrome_plugins = false diff --git a/tools/setup.py b/tools/setup.py index dbb44c5e1..3b0246f51 100755 --- a/tools/setup.py +++ b/tools/setup.py @@ -104,7 +104,9 @@ def generate_gn_args(mode): if mode == "release": out += ["is_official_build=true"] elif mode == "debug": - pass + # Enable Jumbo build by default in debug mode for faster build. + # https://chromium.googlesource.com/chromium/src/+/master/docs/jumbo.md + out += ["use_jumbo_build=true"] else: print "Bad mode {}. Use 'release' or 'debug' (default)" % mode sys.exit(1) -- cgit v1.2.3