From 0982056ff64368451c38b622de90f62fbade89fd Mon Sep 17 00:00:00 2001 From: Kitson Kelly Date: Tue, 10 Nov 2020 10:18:43 +1100 Subject: tests(cli): check ignores dynamic import errors (#8323) Closes #6618 --- cli/module_graph.rs | 18 ++++++++++++++++++ cli/tests/module_graph/file_tests-dynamicimport.ts | 5 +++++ 2 files changed, 23 insertions(+) create mode 100644 cli/tests/module_graph/file_tests-dynamicimport.ts diff --git a/cli/module_graph.rs b/cli/module_graph.rs index bf3972904..0bd51251f 100644 --- a/cli/module_graph.rs +++ b/cli/module_graph.rs @@ -1959,6 +1959,24 @@ pub mod tests { assert_eq!(h.tsbuildinfo_calls.len(), 1); } + #[tokio::test] + async fn test_graph_check_ignores_dynamic_import_errors() { + let specifier = + ModuleSpecifier::resolve_url_or_path("file:///tests/dynamicimport.ts") + .expect("could not resolve module"); + let (graph, _) = setup(specifier).await; + let result_info = graph + .check(CheckOptions { + debug: false, + emit: false, + lib: TypeLib::DenoWindow, + maybe_config_path: None, + reload: false, + }) + .expect("should have checked"); + assert!(result_info.diagnostics.is_empty()); + } + #[tokio::test] async fn fix_graph_check_emit_diagnostics() { let specifier = diff --git a/cli/tests/module_graph/file_tests-dynamicimport.ts b/cli/tests/module_graph/file_tests-dynamicimport.ts new file mode 100644 index 000000000..b5c9f080f --- /dev/null +++ b/cli/tests/module_graph/file_tests-dynamicimport.ts @@ -0,0 +1,5 @@ +try { + await import("bare_module_specifier"); +} catch (err) { + console.log(err); +} -- cgit v1.2.3